Skip to content

add line numbers and error marking #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
graphiteisaac wants to merge 4 commits into
base: main
Choose a base branch
from
+38 −1
Draft

add line numbers and error marking #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
27b72e3
add line numbers and error marking
graphiteisaac Oct 8, 2026
7011169
undo auto-format, whoops!
graphiteisaac Oct 9, 2026
287389e
actually configure line numbers for codeflask.... silly me
graphiteisaac Oct 11, 2026
eb6b414
fix CSS formatting and patch line number background bug
graphiteisaac Oct 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion static/css/code/syntax-highlight.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,35 @@ CodeFlask mappings
--code-token-base
); /* Makes the text input cursor visible in dark mode */
}

.codeflask .codeflask__lines {
background: var(--code-background);
color: var(--code-token-punctuation);
font-family: "SFMono-Regular", Consolas, "Liberation Mono", Menlo, Courier, monospace;

@lpil lpil Oct 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come a different font is being used here?

@graphiteisaac graphiteisaac Oct 11, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's to override what Codeflask sets; I've copied it from the parent element, I believe.

font-size: 13px;
line-height: 20px;
padding: var(--gap) 4px;
}
.codeflask.codeflask--has-line-numbers:before {
/* Codeflask inserts this inline, so it's necessary to override it. */
background: var(--code-background) !important;
}
.codeflask__lines__line {
position: relative;
}
.codeflask__lines__line.line_has_error {
color: var(--brand-error);
}
.codeflask__lines__line.line_has_error:before {
content: '';
display: block;
position: absolute;
left: 0;
top: 5px;
bottom: 5px;
width: 3px;
border-radius: 2px;
background: var(--brand-error);
}
.codeflask {
background: var(--code-background);
color: var(--code-token-base);
Expand Down
9 changes: 9 additions & 0 deletions static/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ function highlightOutput(target, childClassName) {

const editor = new CodeFlask("#editor-target", {
language: "gleam",
lineNumbers: true,
defaultTheme: false,
});
editor.addLanguage("gleam", prismGrammar);
Expand Down Expand Up @@ -134,6 +135,14 @@ worker.onmessage = (event) => {
appendCode(outputEl, result.log, "log");
}
if (result.error) {
const lines = [...result.error.matchAll(/\.gleam:(\d+)/gi)].map(
(x) => x[1],
);
for (const line of lines) {
document
.querySelector(`.codeflask__lines__line:nth-of-type(${line})`)
.classList.add("line_has_error");
}
appendCode(outputEl, result.error, "error");
}
if (result.js) {
Expand Down
Loading