Repository navigation
add line numbers and error marking - #40
graphiteisaac wants to merge 4 commits into
Conversation
lpil
left a comment
lpil
left a comment
There was a problem hiding this comment.
Can you undo the unrelated changes please 🙏
|
Oops, my formatter ran but it didn't look visually different in my editor... lol, will fix |
lpil
left a comment
lpil
left a comment
There was a problem hiding this comment.
I checked out this branch and ran it but I don't see line numbers or any marking for errors? Is there something else I need to do?
| .codeflask .codeflask__lines { | ||
| background: var(--code-background); | ||
| color: var(--code-token-punctuation); | ||
| font-family: "SFMono-Regular", Consolas, "Liberation Mono", Menlo, Courier, monospace; |
There was a problem hiding this comment.
How come a different font is being used here?
There was a problem hiding this comment.
It's to override what Codeflask sets; I've copied it from the parent element, I believe.
Tremendously embarrassing; but when I rolled back to fix the formatting issues, I didn't re-add the config option... it will work now. |
Maybe it's just me, but it looks like there's too much space to the left of the line numbers initially. It looks better with 10+ lines though. Not sure there's anything to be done really... 
I found this weird bug though! |
|
That bug is odd, I'll fix it. The left side spacing is awkward with few lines but I think it would be far more awkward to have it shift visually when you add more lines. |
|
Is this ready for review @graphiteisaac ? :) |
Yes, sorry I didn't say so earlier! |
Simple one - adds line numbers and marks errors on the line they're at. The way I'm doing the error highlighting is a little funky but it's dead simple (CSS class applied to lines, based on regex matching the error message), which I think is fine for something like this.