Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for invalid target in attribute #4369

Merged
merged 5 commits into from
Mar 19, 2025
+98 −11
Merged

Improve error message for invalid target in attribute #4369

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9106f20
Improve error message for unknown target name
AlecGhost Mar 17, 2025
cad80c7
Improve error message for missing target name
AlecGhost Mar 17, 2025
62d16ad
Remove unnecessary struct init in expect_target
AlecGhost Mar 18, 2025
f3b8017
CHANGELOG
AlecGhost Mar 18, 2025
1a3d33a
Fix Changelog text
AlecGhost Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
CHANGELOG
@AlecGhost
AlecGhost committed Mar 18, 2025
commit f3b8017cc28882d230b9d207bf07d22a9f0a3bf7
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -222,6 +222,10 @@
- Fixed a bug where variant inference wouldn't work on `let assert` assignments.
([Giacomo Cavalieri](https://github.com/giacomocavalieri))

- Fixed a bug where the error message for an unknown or missing target name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a bug!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would you classify it? It seems like undesired behaviour to me.
Should I move it to the compiler section instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an improvement to compiler error messages, there was nothing not-working previously so it's not a bug fix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, thanks a lot for reviewing everything so quickly and in-depth.

in the target attribute would point to a subsequent token.
([Alexander Keleschovsky](https://github.com/AlecGhost))

## v1.9.1 - 2025-03-10

### Formatter