Improve error message for invalid target in attribute #4369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpil
reviewed
Mar 18, 2025
compiler-core/src/parse.rs
Outdated
| let (start, t, end) = match self.next_tok() { | ||
| Some(t) => t, | ||
| None => { | ||
| return parse_error(ParseErrorType::UnexpectedEof, SrcSpan { start: 0, end: 0 }); | ||
| } | ||
| }; | ||
| let location = SrcSpan::new(start, end); |
There was a problem hiding this comment.
Only build this when it is needed please 🙏
lpil
reviewed
Mar 18, 2025
CHANGELOG.md
Outdated
| @@ -222,6 +222,10 @@ | |||
| - Fixed a bug where variant inference wouldn't work on `let assert` assignments. | |||
| ([Giacomo Cavalieri](https://github.com/giacomocavalieri)) | |||
|
|
|||
| - Fixed a bug where the error message for an unknown or missing target name | |||
There was a problem hiding this comment.
How would you classify it? It seems like undesired behaviour to me.
Should I move it to the compiler section instead?
There was a problem hiding this comment.
This is an improvement to compiler error messages, there was nothing not-working previously so it's not a bug fix.
There was a problem hiding this comment.
Btw, thanks a lot for reviewing everything so quickly and in-depth.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Issue #4362.
UnknownTargeterror in case the target name is neitherjavascriptnorerlangExpectedTargetNameerror in case the target is missing