Skip to content

MySQL修正 #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
a-miyashita merged 5 commits into from
Jun 28, 2025
Merged

MySQL修正 #58

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
70515bd
fix debug --client に mysql を追加
Syogo-Suganoya Jun 27, 2025
7e9bed9
fix MySQL clean 修正
Syogo-Suganoya Jun 27, 2025
db174e0
fix MySQLCassette.listFk SQL文修正
Syogo-Suganoya Jun 27, 2025
87990f6
fix MySQL auto_increment プレースホルダを使った計算式を削除
Syogo-Suganoya Jun 27, 2025
22ea4ce
update npm package version
Syogo-Suganoya Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/connection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ class MySQLCassette {
`;
}
updateAutoIncrementSql(table, column) {
return `ALTER TABLE ${table} AUTO_INCREMENT = ? + 1`;
return `ALTER TABLE ${table} AUTO_INCREMENT = ?`;
Comment on lines -270 to +272
Copy link
Contributor Author

@Syogo-Suganoya Syogo-Suganoya Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MySQLではプレースホルダを使った計算式はエラーが出るようなので、+1を削除しました。
updateAutoIncrement の方で、MySQLCassetteの場合のみ、count+1するようにしました。

Copy link
Contributor Author

@Syogo-Suganoya Syogo-Suganoya Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

既存のSQLiteチャレンジでも、影響なく正常に動作することを確認です。

}
lastValueSql(table, idCol) {
return `SELECT * FROM ${table} WHERE ${idCol} = LAST_INSERT_ID()`;
Expand Down Expand Up @@ -594,6 +594,9 @@ class Connection {

async updateAutoIncrement(table, column, count) {
const sql = this._cassette.updateAutoIncrementSql(table, column);
if (this._cassette instanceof MySQLCassette) {
count = (count || 0) + 1;
}
return await this.query(sql, [count]);
}

Expand Down