MySQL修正 #58
Merged
MySQL修正 #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Syogo-Suganoya
commented
Jun 27, 2025
Contributor
Author
Syogo-Suganoya
left a comment
Syogo-Suganoya
left a comment
There was a problem hiding this comment.
@a-miyashita review me
タグは v2.6.0-rc8 でつけています。
一応、ローカルで動作確認済みです。
| Options: | ||
| --clean Remove all objects before execution. | ||
| -c --client <client> Kind of Database Client [sqlite, postgres; default sqlite] | ||
| -c --client <client> Kind of Database Client [sqlite, postgres, mysql; default sqlite] |
Contributor
Author
There was a problem hiding this comment.
debugコマンドのUSAGEのclientオプションにmysqlを追加しました。
- issue: debugコマンドのclientオプションのUSAGE修正
- commit: 70515bd
Comment on lines
+238
to
+242
| await conn.raw("SET foreign_key_checks = 0"); | ||
| for (let table of tables[0]) { | ||
| await conn.raw(`DROP TABLE IF EXISTS ${table.Tables_in_track} CASCADE`); | ||
| await conn.raw(`DROP TABLE IF EXISTS ${table.Tables_in_track}`); | ||
| } | ||
| await conn.raw("SET foreign_key_checks = 1"); |
Contributor
Author
There was a problem hiding this comment.
テーブルを削除する際に、外部キーをオフにしてから、削除するようにしました。
MySQLにCASCADEがないためです。
- issue: 外部キー使用で、debug --clean実行時にUNKNOWN_CODE_PLEASE_REPORT
- commit: 7e9bed9
Comment on lines
-280
to
+287
| kcu.column_name AS column, | ||
| ccu.table_name AS foreign_table, | ||
| ccu.column_name AS foreign_column | ||
| FROM information_schema.table_constraints AS tc | ||
| INNER JOIN information_schema.key_column_usage AS kcu ON tc.constraint_name = kcu.constraint_name | ||
| INNER JOIN information_schema.constraint_column_usage AS ccu ON ccu.constraint_name = tc.constraint_name | ||
| WHERE tc.constraint_type = 'FOREIGN KEY' AND tc.table_name = '${table}' | ||
| COLUMN_NAME AS \`column\`, | ||
| REFERENCED_TABLE_NAME AS foreign_table, | ||
| REFERENCED_COLUMN_NAME AS foreign_column | ||
| FROM information_schema.KEY_COLUMN_USAGE | ||
| WHERE | ||
| TABLE_SCHEMA = DATABASE() | ||
| AND TABLE_NAME = '${table}' | ||
| AND REFERENCED_TABLE_NAME IS NOT NULL |
Contributor
Author
There was a problem hiding this comment.
listFkのSQL文をMySQLのものに修正しました。
- issue: 外部キー使用で、table実行時にlistFkでER_PARSE_ERROR
- commit: db174e0
| } | ||
| updateAutoIncrementSql(table, column) { | ||
| return `ALTER TABLE ${table} AUTO_INCREMENT = ? + 1`; | ||
| return `ALTER TABLE ${table} AUTO_INCREMENT = ?`; |
Contributor
Author
There was a problem hiding this comment.
MySQLではプレースホルダを使った計算式はエラーが出るようなので、+1を削除しました。
updateAutoIncrement の方で、MySQLCassetteの場合のみ、count+1するようにしました。
- issue: auto_incrementでER_PARSE_ERROR
- commit: 87990f6
Contributor
Author
There was a problem hiding this comment.
既存のSQLiteチャレンジでも、影響なく正常に動作することを確認です。
a-miyashita
approved these changes
Jun 28, 2025
Collaborator
a-miyashita
left a comment
a-miyashita
left a comment
There was a problem hiding this comment.
修正ありがとうございます。これで完成となったら version の rc を取ってリリースしてください。リリース用の PR は僕のレビューは不要です。
Collaborator
|
リリース僕の方でやりました |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#53