Skip to content

no_fullscanの判定が効かない #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Syogo-Suganoya merged 4 commits into from
Jan 27, 2025
Merged

no_fullscanの判定が効かない #52

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
72c178f
fix fullscan の判定文字列を SCAN に変更
Syogo-Suganoya Jan 26, 2025
6d020d5
fix fullscan の判定文字列の TABLE を任意に変更
Syogo-Suganoya Jan 26, 2025
fa662cc
update npm package version
Syogo-Suganoya Jan 27, 2025
a7b5311
update npm package version
Syogo-Suganoya Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/assertions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ module.exports = function(chai, util) {

function fullscan(records, tables, every) {
const re = new RegExp(
`^SCAN TABLE (${(tables || []).join('|') || '\\w+'})`
`^SCAN(?: TABLE)? (${(tables || []).join('|') || '\\w+'})`
Copy link
Contributor Author

@Syogo-Suganoya Syogo-Suganoya Jan 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SCAN {テーブル名}でもSCAN TABLE{テーブル名}でも検知するようにしました。

Copy link
Contributor Author

@Syogo-Suganoya Syogo-Suganoya Jan 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

理由

SCAN TABLE {テーブル名}ではなく、SCAN {テーブル名}のフォーマットで出力されます。

EXPLAIN QUERY PLANの結果

不正解時

id parent notused detail
2 0 0 SCAN sports

正解時

id parent notused detail
3 0 0 SEARCH sports USING INDEX sports_name_idx (name=?)

確認可能なコンテンツ

スポーツ検索システムのデータベース構築をせよ SQL編 で確認可能です。
TCM
https://new.tracks.dev/app/01GGP9MCKKDADZ4HQATZG3FXM3/materials?statuses=2&shipStatuses=shipped&keyword=sql-design-sport&selectedId=2-4990

Copy link
Contributor Author

@Syogo-Suganoya Syogo-Suganoya Jan 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

備考

SCAN {テーブル名}になる原因も調査してみましたが、別名テーブルやサブクエリを使用しているとなるようです。
しかし、そのような箇所はないはずなので、原因としては不明なままです。

);
return records[every ? 'every' : 'some'](record => re.test(record.detail));
}
Expand Down
Loading