no_fullscanの判定が効かない #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Syogo-Suganoya
commented
Jan 26, 2025
Contributor
Author
Syogo-Suganoya
left a comment
Syogo-Suganoya
left a comment
There was a problem hiding this comment.
@a-miyashita review me
| function fullscan(records, tables, every) { | ||
| const re = new RegExp( | ||
| `^SCAN TABLE (${(tables || []).join('|') || '\\w+'})` | ||
| `^SCAN(?: TABLE)? (${(tables || []).join('|') || '\\w+'})` |
Contributor
Author
There was a problem hiding this comment.
SCAN {テーブル名}でもSCAN TABLE{テーブル名}でも検知するようにしました。
Contributor
Author
There was a problem hiding this comment.
理由
SCAN TABLE {テーブル名}ではなく、SCAN {テーブル名}のフォーマットで出力されます。
EXPLAIN QUERY PLANの結果
不正解時
| id | parent | notused | detail |
|---|---|---|---|
| 2 | 0 | 0 | SCAN sports |
正解時
| id | parent | notused | detail |
|---|---|---|---|
| 3 | 0 | 0 | SEARCH sports USING INDEX sports_name_idx (name=?) |
確認可能なコンテンツ
スポーツ検索システムのデータベース構築をせよ SQL編 で確認可能です。
TCM
https://new.tracks.dev/app/01GGP9MCKKDADZ4HQATZG3FXM3/materials?statuses=2&shipStatuses=shipped&keyword=sql-design-sport&selectedId=2-4990
Contributor
Author
There was a problem hiding this comment.
備考
SCAN {テーブル名}になる原因も調査してみましたが、別名テーブルやサブクエリを使用しているとなるようです。
しかし、そのような箇所はないはずなので、原因としては不明なままです。
a-miyashita
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
テストで
no_fullscanを使用しましたが、フルスキャンが行われている際も、正解判定がされます。track-db-test-library/doc/DEVELOPPING_SQL_CHALLENGES_ja.md
Line 468 in 7350016