Repository navigation
Share Sentry hostname recognition across CLI and MCP #1430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+45
−13
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,10 @@ | ||
| # Toolkit core | ||
|
|
||
| Pure authentication protocol helpers shared by the CLI and MCP. Both product | ||
| Pure protocol and hostname helpers shared by the CLI and MCP. Both product | ||
| builds bundle this private workspace package into their artifacts. | ||
|
|
||
| The shared code validates opaque bearer tokens, constructs OAuth device-flow | ||
| form bodies, and applies the RFC 8628 polling interval rule. Each product | ||
| retains its own credential storage, host trust checks, polling deadline, HTTP | ||
| transport, response validation, and user-facing error types. | ||
| form bodies, applies the RFC 8628 polling interval rule, and recognizes Sentry | ||
| hostnames. Each product retains its own credential storage, URL and host trust | ||
| checks, regional routing, polling deadline, HTTP transport, response validation, | ||
| and user-facing error types. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| import { describe, expect, it } from "vitest"; | ||
| import { isSentryHost } from "./sentry-host"; | ||
|
|
||
| describe("isSentryHost", () => { | ||
| it.each(["sentry.io", "us.sentry.io", "tenant.my.sentry.io"])( | ||
| "recognizes %s as a Sentry hostname", | ||
| (host) => { | ||
| expect(isSentryHost(host)).toBe(true); | ||
| }, | ||
| ); | ||
|
|
||
| it.each([ | ||
| "", | ||
| "sentry.io.example.com", | ||
| "notsentry.io", | ||
| "sentry.io.", | ||
| "SENTRY.IO", | ||
| ])("does not classify %s as a Sentry hostname", (host) => { | ||
| expect(isSentryHost(host)).toBe(false); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| /** Classify a parsed hostname as Sentry-owned, including regional and tenant hosts. */ | ||
| export function isSentryHost(host: string): boolean { | ||
| return host === "sentry.io" || host.endsWith(".sentry.io"); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, get rid of this please. All consumers should use the shared util. Never do this kind of silly wrapping again.