Skip to content

Share Sentry hostname recognition across CLI and MCP - #1430

Merged
BYK merged 1 commit into
mainfrom
feat/toolkit-core-sentry-host
Oct 6, 2026
Merged

BYK merged 1 commit into
mainfrom
feat/toolkit-core-sentry-host

Conversation

@BYK

@BYK BYK commented Oct 6, 2026

Copy link
Copy Markdown
Member

Summary

  • Move the common Sentry-owned hostname predicate to the private toolkit-core package.
  • Keep CLI URL parsing and MCP public/tenant classification as separate product policies.
  • Allow the pure hostname helper through the CLI startup-import test while still traversing it for eager SDK imports.

Validation

  • pnpm run tsc && pnpm run lint && pnpm run test (combined tree, with an owned temporary test root)
  • pnpm run pre-commit:generated && pnpm run docs:check
  • oxfmt --check on changed source, test, and package files

The combined-tree test run passed 10,526 CLI tests, 1,752 MCP-core tests, 433 Cloudflare tests, and the remaining workspace suites.

Keep product-specific URL and credential trust policies while sharing the exact Sentry hostname predicate.

Co-Authored-By: GPT-6 Sol <agent@openai.com>
@github-actions github-actions Bot added the risk: low PR risk score: low label Oct 6, 2026
@BYK
BYK merged commit ca610fd into main Oct 6, 2026
32 checks passed
@BYK
BYK deleted the feat/toolkit-core-sentry-host branch October 6, 2026 20:06
/**
* Recognizes Sentry-owned hosts, including single-tenant deployments.
*/
/** Keep the MCP utility export for its existing consumers. */

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, get rid of this please. All consumers should use the shared util. Never do this kind of silly wrapping again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: low PR risk score: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant