ref: wrap BILLED_DATA_CATEGORY_INFO behind getBilledDataCategoryInfo()

static/gsAdmin/components/addGiftEventsAction.spec.tsx

@@ -7,7 +7,7 @@ import {DataCategory, DataCategoryExact} from 'sentry/types/core';
 
 import {AddGiftEventsAction} from 'admin/components/addGiftEventsAction';
 import {openAdminConfirmModal} from 'admin/components/adminConfirmationModal';
-import {BILLED_DATA_CATEGORY_INFO} from 'getsentry/constants';
+import {getBilledDataCategoryInfo} from 'getsentry/constants';
 import {getCategoryInfoFromPlural} from 'getsentry/utils/dataCategory';
 
 describe('AddGiftEventsAction', () => {
@@ -18,7 +18,7 @@ describe('AddGiftEventsAction', () => {
   const triggerGiftModal = () => {
     const billedCategoryInfo = categoryOverride
       ? getCategoryInfoFromPlural(categoryOverride)
-      : BILLED_DATA_CATEGORY_INFO[DataCategoryExact.SPAN];
+      : getBilledDataCategoryInfo()[DataCategoryExact.SPAN];
     openAdminConfirmModal({
       renderModalSpecificContent: deps => (
         <AddGiftEventsAction

static/gsAdmin/components/customers/customerOverview.tsx

@@ -28,7 +28,7 @@ import {DetailList} from 'admin/components/detailList';
 import {DetailsContainer} from 'admin/components/detailsContainer';
 import {ExtendProductTrialAction} from 'admin/components/extendProductTrialAction';
 import {getLogQuery} from 'admin/utils';
-import {BILLED_DATA_CATEGORY_INFO, UNLIMITED} from 'getsentry/constants';
+import {getBilledDataCategoryInfo, UNLIMITED} from 'getsentry/constants';
 import type {
   Plan,
   ReservedBudget,
@@ -482,7 +482,7 @@ export function CustomerOverview({customer, onAction, organization}: Props) {
   // TODO(cells) We also should show the customer's cell.
   const locality = localityMap[organization.links.regionUrl] ?? '??';
 
-  const productTrialCategories = Object.values(BILLED_DATA_CATEGORY_INFO).filter(
+  const productTrialCategories = Object.values(getBilledDataCategoryInfo()).filter(
     categoryInfo => {
       // Category must be in the plan's categories
       if (!customer.planDetails?.categories.includes(categoryInfo.plural)) {

static/gsApp/components/gsBanner.tsx

@@ -44,7 +44,7 @@ import {ProductTrialAlert} from 'getsentry/components/productTrial/productTrialA
 import {getProductForPath} from 'getsentry/components/productTrial/productTrialPaths';
 import {makeLinkToOwnersAndBillingMembers} from 'getsentry/components/profiling/alerts';
 import {withSubscription} from 'getsentry/components/withSubscription';
-import {BILLED_DATA_CATEGORY_INFO} from 'getsentry/constants';
+import {getBilledDataCategoryInfo} from 'getsentry/constants';
 import {SubscriptionStore} from 'getsentry/stores/subscriptionStore';
 import {
   type BilledDataCategoryInfo,
@@ -80,7 +80,7 @@ enum ModalType {
 const TRIAL_ENDING_DAY_WINDOW = 3;
 
 function objectFromBilledCategories(callback: (c: BilledDataCategoryInfo) => any) {
-  return Object.values(BILLED_DATA_CATEGORY_INFO).reduce(
+  return Object.values(getBilledDataCategoryInfo()).reduce(
     (acc, c) => {
       if (c.isBilledCategory) {
         acc[c.singular as EventType] = callback(c);
@@ -634,7 +634,7 @@ class GSBanner extends Component<Props, State> {
     const category_warning_prompts: string[] = [];
     const category_product_trial_prompts: string[] = [];
 
-    Object.values(BILLED_DATA_CATEGORY_INFO)
+    Object.values(getBilledDataCategoryInfo())
       .filter(
         categoryInfo =>
           categoryInfo.isBilledCategory &&

static/gsApp/constants.tsx

@@ -77,7 +77,7 @@ Object.entries(DEFAULT_BILLED_DATA_CATEGORY_INFO).forEach(
  * All categories with isBilledCategory: true, should be explicitly
  * added to this object with billing info.
  */
-export const BILLED_DATA_CATEGORY_INFO = {
+const BILLED_DATA_CATEGORY_INFO = {
   ...DEFAULT_BILLED_DATA_CATEGORY_INFO,
   [DataCategoryExact.ERROR]: {
     ...DEFAULT_BILLED_DATA_CATEGORY_INFO[DataCategoryExact.ERROR],
@@ -234,3 +234,14 @@ export const BILLED_DATA_CATEGORY_INFO = {
     adminOnlyProductTrialFeature: 'expose-category-installable-build',
   },
 } as const satisfies Record<DataCategoryExact, BilledDataCategoryInfo>;
+
+/**
+ * Returns billing-enriched data category info for all categories.
+ * This wraps the static constant so it can later be replaced with a backend call.
+ */
+export function getBilledDataCategoryInfo(): Record<
+  DataCategoryExact,
+  BilledDataCategoryInfo
+> {
+  return BILLED_DATA_CATEGORY_INFO;
+}

static/gsApp/utils/dataCategory.tsx

@@ -6,7 +6,7 @@ import {DataCategory, DataCategoryExact} from 'sentry/types/core';
 import {oxfordizeArray} from 'sentry/utils/oxfordizeArray';
 import {toTitleCase} from 'sentry/utils/string/toTitleCase';
 
-import {BILLED_DATA_CATEGORY_INFO, UNLIMITED_RESERVED} from 'getsentry/constants';
+import {getBilledDataCategoryInfo, UNLIMITED_RESERVED} from 'getsentry/constants';
 import type {
   BilledDataCategoryInfo,
   BillingMetricHistory,
@@ -28,7 +28,9 @@ import {MILLISECONDS_IN_HOUR} from 'getsentry/utils/billing';
 export function getCategoryInfoFromPlural(
   category: DataCategory
 ): BilledDataCategoryInfo | null {
-  const info = Object.values(BILLED_DATA_CATEGORY_INFO).find(c => c.plural === category);
+  const info = Object.values(getBilledDataCategoryInfo()).find(
+    c => c.plural === category
+  );
   if (!info) {
     return null;
   }

static/gsApp/views/spendAllocations/components/allocationForm.tsx

@@ -20,7 +20,7 @@ import type {RequestMethod} from 'sentry/utils/api/apiQueryKey';
 import {useApi} from 'sentry/utils/useApi';
 import {useOrganization} from 'sentry/utils/useOrganization';
 
-import {AllocationTargetTypes, BILLED_DATA_CATEGORY_INFO} from 'getsentry/constants';
+import {AllocationTargetTypes, getBilledDataCategoryInfo} from 'getsentry/constants';
 import type {Subscription} from 'getsentry/types';
 import {
   getCategoryInfoFromPlural,
@@ -541,10 +541,10 @@ const Select = styled(SelectField)`
   }
 `;
 
-// Normalizes singular billingMetric values to match DataCategory enum using BILLED_DATA_CATEGORY_INFO
+// Normalizes singular billingMetric values to match DataCategory enum using getBilledDataCategoryInfo()
 function normalizeBillingMetric(metric: string): DataCategory {
   return (
-    Object.values(BILLED_DATA_CATEGORY_INFO)
+    Object.values(getBilledDataCategoryInfo())
       .filter(info => info.canAllocate)
       .find(c => c.name === metric)?.plural ?? (metric as DataCategory)
   );