ref: wrap BILLED_DATA_CATEGORY_INFO behind getBilledDataCategoryInfo()#118078
Open
volokluev wants to merge 3 commits into
Open
ref: wrap BILLED_DATA_CATEGORY_INFO behind getBilledDataCategoryInfo()#118078volokluev wants to merge 3 commits into
volokluev wants to merge 3 commits into
Conversation
Prepare for moving billed data category info to a backend call by hiding the static constant behind a function. All consumers now call getBilledDataCategoryInfo() instead of importing the constant directly.
github-actions
Bot
added
the
Scope: Frontend
volokluev
commented
Jun 18, 2026
Address review feedback: the function is not a constant, so move it out of constants.tsx into utils/dataCategory.tsx where related helpers already live. The constant remains exported from constants.tsx and the function imports it from there.
Move the entire constant definition out of constants.tsx into utils/dataCategory.tsx alongside getBilledDataCategoryInfo(). The constant is now private to dataCategory.tsx and only accessible through the function.
Contributor
📊 Type Coverage Diff
🔍 2 new type safety issues introducedType assertions (
This is informational only and does not block the PR. |
armenzg
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BILLED_DATA_CATEGORY_INFOconstant behind agetBilledDataCategoryInfo()function to prepare for moving this data to a backend API call.Test plan