Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions static/app/views/dashboards/utils.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,30 @@ describe('Dashboards util', () => {
const urlParams = new URLSearchParams(queryString);
expect(urlParams.get('query')).toBe('(is:unresolved) release:["1.0.0","2.0.0"] ');
});
it('applies global filters scoped to the issue dataset', () => {
const url = getWidgetIssueUrl(
widget,
{
globalFilter: [
{
dataset: WidgetType.ISSUE,
tag: {key: 'transaction', name: 'transaction'},
value: 'transaction:/api/foo',
},
{
dataset: WidgetType.DISCOVER,
tag: {key: 'transaction', name: 'transaction'},
value: 'transaction:/api/bar',
},
],
},
selection,
OrganizationFixture()
);
const queryString = url.split('?')[1];
const urlParams = new URLSearchParams(queryString);
expect(urlParams.get('query')).toBe('(is:unresolved) transaction:/api/foo');
});
});

describe('flattenErrors', () => {
Expand Down
6 changes: 5 additions & 1 deletion static/app/views/dashboards/utils.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,11 @@ export function getWidgetIssueUrl(
? {start: getUtcDateString(start), end: getUtcDateString(end), utc}
: {statsPeriod: period};
const issuesLocation = `/organizations/${organization.slug}/issues/?${qs.stringify({
query: applyDashboardFilters(widget.queries?.[0]?.conditions, dashboardFilters),
query: applyDashboardFilters(
widget.queries?.[0]?.conditions,
dashboardFilters,
widget.widgetType
),
sort: widget.queries?.[0]?.orderby,
...datetime,
// Pass empty string when projects is empty to preserve "My Projects" selection in URL
Comment thread
DominikB2014 marked this conversation as resolved.
Expand Down
Loading