feat(billing): Use Intercom for ask Support links#115527
Open
souredoutlook wants to merge 3 commits into
Open
Conversation
Wire the remaining "Contact Support" surfaces in the billing flow to
Intercom when the intercom-support feature is enabled, falling back to
the existing ZendeskLink otherwise. Affects:
- gsBanner suspension modal
- TrialEnded alert on the subscription overview
- PlanMigrationActive panel for scheduled legacy-plan migrations
Mirrors the pattern in the primary nav help menu and checkout side
panel. On Intercom failure, falls back to mailto with the same subject
the ZendeskLink used. Adds intercom_link.viewed/clicked analytics with
sources matching each surface's existing Zendesk source
('account-suspension', 'trial', 'billing').
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
scraps Button's discriminated union requires children when no
aria-label is provided. The tct-interpolated <Button /> in TrialEnded
and PlanMigrationActive has neither at the JSX site since children
are injected at runtime by tct's cloneElement. Pass {null} as a
placeholder so the type checks; tct overwrites it.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
The Intercom failure path on the checkout side panel fell back to a bare mailto, dropping the "Billing Question" subject the original ZendeskLink provided. Restore it for consistency with the suspension, trial, and plan-migration surfaces, which all include their original subjects in the mailto fallback. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.51% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the three remaining billing-page "Contact Support" / "ask Support" surfaces to use Intercom behind the
intercom-supportfeature flag, falling back to<ZendeskLink>(which itself falls back to mailto) when the flag is off, and to mailto with the surface's original subject line whenshowIntercomthrows. Mirrors the pattern already shipped in the primary nav help menu (#108409) and checkout side panel (#115218).Surfaces migrated:
SuspensionModalingsBanner.tsx— "Contact Support" button in the account-suspension modal footerTrialEndedalert on the subscription overview — "contact support" link to request another trialPlanMigrationActivepanel — "Support" link in the legacy-plan-migration noticeAlso includes a one-line follow-up to checkout (#115218) to preserve the original
"Billing Question"subject on its Intercom mailto fallback, addressing a Bugbot comment from #115390.Analytics: each surface fires
intercom_link.viewed/intercom_link.clickedwith the source label its existing<ZendeskLink>already used ('account-suspension','trial','billing').Notes
Replaces #115390, which had a divergent history due to being branched off the pre-squash version of #115218 — re-cut cleanly on top of current master with no force-push.