Skip to content

Souredoutlook/feat/billing ask support intercom#115390

Closed
souredoutlook wants to merge 5 commits into
masterfrom
souredoutlook/feat/billing-ask-support-intercom
Closed

Souredoutlook/feat/billing ask support intercom#115390
souredoutlook wants to merge 5 commits into
masterfrom
souredoutlook/feat/billing-ask-support-intercom

Conversation

@souredoutlook
Copy link
Copy Markdown
Contributor

We missed some areas of the product that still have invoke the Zendesk form

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

souredoutlook and others added 3 commits May 8, 2026 15:14
Wire the checkout side-panel "ask Support" link to Intercom when the
intercom-support feature is enabled, falling back to the existing
Zendesk widget otherwise. Mirrors the pattern in the primary nav help
menu and adds intercom_link.viewed/clicked analytics with
source: 'checkout'.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
When showIntercom throws and Zendesk is unavailable, the catch block
silently swallowed the error, leaving the user with no way to reach
support. Fall back to mailto using the configured supportEmail, mirroring
the pattern in the primary nav help menu.

Co-Authored-By: Claude <noreply@anthropic.com>
Wire the remaining "Contact Support" surfaces in the billing flow to
Intercom when the intercom-support feature is enabled, falling back to
the existing ZendeskLink otherwise. Affects:

- gsBanner suspension modal
- TrialEnded alert on the subscription overview
- PlanMigrationActive panel for scheduled legacy-plan migrations

Mirrors the pattern in the primary nav help menu and checkout side
panel. On Intercom failure, falls back to mailto with the same subject
the ZendeskLink used. Adds intercom_link.viewed/clicked analytics with
sources matching each surface's existing Zendesk source
('account-suspension', 'trial', 'billing').

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@souredoutlook souredoutlook requested a review from a team as a code owner May 12, 2026 16:52
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 12, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 12, 2026

📊 Type Coverage Diff

✅ No new type safety issues introduced. Coverage: 93.49%

Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 82ce5a3. Configure here.

Comment thread static/gsApp/views/amCheckout/index.tsx Outdated
Comment thread static/gsApp/views/subscriptionPage/trial/trialEnded.tsx
scraps Button's discriminated union requires children when no
aria-label is provided. The tct-interpolated <Button /> in TrialEnded
and PlanMigrationActive has neither at the JSX site since children
are injected at runtime by tct's cloneElement. Pass {null} as a
placeholder so the type checks; tct overwrites it.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
The Intercom failure path on the checkout side panel fell back to a
bare mailto, dropping the "Billing Question" subject the original
ZendeskLink provided. Restore it for consistency with the suspension,
trial, and plan-migration surfaces, which all include their original
subjects in the mailto fallback.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@souredoutlook
Copy link
Copy Markdown
Contributor Author

Superseded by #115527. This PR was branched off the pre-squash history of #115218, which created a divergence after that PR squash-merged to master. The replacement is re-cut cleanly on top of current master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant