Skip to content

ref(flags): Move 2 should-be-permanent flags to permanent.py #114934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wedamija merged 2 commits into from
May 6, 2026
+17 −12

ref(features): Add permanent_system_features dict

539e632
Select commit
Loading
Failed to load commit list.
Merged

ref(flags): Move 2 should-be-permanent flags to permanent.py #114934

ref(features): Add permanent_system_features dict
539e632
Select commit
Loading
Failed to load commit list.
@sentry/warden / warden: sentry-backend-bugs completed May 5, 2026 in 13s

1 issue

sentry-backend-bugs: Found 1 issue (1 medium)

Medium

auth:register system feature loses explicit api_expose=False - `src/sentry/features/permanent.py:179-185`

The previous registration of system:multi-region passed api_expose=False explicitly. The new loop registers both auth:register and system:multi-region without passing api_expose, so both will use the manager.add default. If the default for api_expose is True (or differs from False), this silently exposes auth:register and system:multi-region via the API, which is a behavior change despite the PR claiming none. Verify FeatureManager.add's api_expose default before merging.

Duration: 12.7s · Tokens: 33.5k in / 536 out · Cost: $0.17

Annotations

Check warning on line 185 in src/sentry/features/permanent.py

See this annotation in the file changed.

@sentry-warden sentry-warden / warden: sentry-backend-bugs

auth:register system feature loses explicit api_expose=False 

The previous registration of system:multi-region passed api_expose=False explicitly. The new loop registers both auth:register and system:multi-region without passing api_expose, so both will use the manager.add default. If the default for api_expose is True (or differs from False), this silently exposes auth:register and system:multi-region via the API, which is a behavior change despite the PR claiming none. Verify FeatureManager.add's api_expose default before merging.
View more details on @sentry/warden