Skip to content

ref(features): Add permanent_system_features dict

539e632
Select commit
Loading
Failed to load commit list.
Merged

ref(flags): Move 2 should-be-permanent flags to permanent.py #114934

ref(features): Add permanent_system_features dict
539e632
Select commit
Loading
Failed to load commit list.
@sentry/warden / warden completed May 5, 2026 in 18s

1 issue

Medium

auth:register system feature loses explicit api_expose=False - `src/sentry/features/permanent.py:179-185`

The previous registration of system:multi-region passed api_expose=False explicitly. The new loop registers both auth:register and system:multi-region without passing api_expose, so both will use the manager.add default. If the default for api_expose is True (or differs from False), this silently exposes auth:register and system:multi-region via the API, which is a behavior change despite the PR claiming none. Verify FeatureManager.add's api_expose default before merging.

5 skills analyzed
Skill Findings Duration Cost
sentry-backend-bugs 1 12.7s $0.17
wrdn-pii 0 8.0s $0.14
wrdn-authz 0 13.1s $0.14
wrdn-code-execution 0 9.9s $0.14
wrdn-data-exfil 0 14.8s $0.14

Duration: 58.5s · Tokens: 182.2k in / 624 out · Cost: $0.72