Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"babel-jest": "^29.7.0",
"jest": "^29.7.0",
"react": "18.3.1",
"react-native": "0.77.1",
"react-native": "0.85.3",
Comment on lines 25 to +26
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React 18 incompatible with React Native 0.85.3

React Native 0.85.3 requires React 19; keeping react at 18.3.1 here will likely cause runtime errors in the e2e test environment.

Evidence
  • samples/react-native/package.json uses react-native: 0.85.3 paired with react: 19.2.3.
  • packages/core/package.json lists react: 19.1.0 alongside the same RN version bump.
  • performance-tests/TestAppPlain/package.json also uses react: 19.2.3 with RN 0.85.x.
  • React Native 0.84 changelog (cited in the PR body) makes Hermes V1 default and removes APIs that depend on React 18 internals, making React 19 a hard requirement.
  • This file alone still declares react: 18.3.1, creating a mismatch that will break the e2e test suite at runtime.

Identified by Warden code-review · M3V-F4Y

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix attempt detected (commit 535754a)

The file was modified to bump react-native to 0.85.3 but react remains at 18.3.1, leaving the version mismatch unresolved.

The original issue appears unresolved. Please review and try again.

Evaluated by Warden

"react-native-launch-arguments": "^4.0.2",
"typescript": "4.9.5",
"webdriverio": "^8.27.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@
"oxlint": "^1.56.0",
"oxlint-tsgolint": "^0.17.4",
"react": "19.1.0",
"react-native": "0.80.1",
"react-native": "0.85.3",
"react-test-renderer": "19.1.0",
"rimraf": "^4.1.1",
"ts-jest": "^29.3.1",
Expand Down
2 changes: 1 addition & 1 deletion performance-tests/TestAppPlain/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
},
"dependencies": {
"react": "19.2.3",
"react-native": "0.85.1"
"react-native": "0.85.3"
},
"devDependencies": {
"@babel/core": "^7.25.2",
Comment thread
sentry-warden[bot] marked this conversation as resolved.
Comment thread
sentry-warden[bot] marked this conversation as resolved.
Expand Down
2 changes: 1 addition & 1 deletion performance-tests/TestAppSentry/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"@react-native/new-app-screen": "0.85.1",
"@sentry/react-native": "8.12.0",
"react": "19.2.3",
"react-native": "0.85.1"
"react-native": "0.85.3"
},
"devDependencies": {
"@babel/core": "^7.25.2",
Expand Down
2 changes: 1 addition & 1 deletion samples/expo/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"expo-web-browser": "~55.0.9",
"react": "19.2.0",
"react-dom": "19.2.0",
"react-native": "0.83.2",
"react-native": "0.85.3",
"react-native-gesture-handler": "~2.30.0",
"react-native-safe-area-context": "~5.6.0",
"react-native-screens": "~4.23.0",
Expand Down
2 changes: 1 addition & 1 deletion samples/react-native-macos/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"@sentry/react-native": "8.12.0",
"delay": "^6.0.0",
"react": "18.2.0",
Comment thread
sentry-warden[bot] marked this conversation as resolved.
"react-native": "0.73.9",
"react-native": "0.85.3",

Check failure on line 24 in samples/react-native-macos/package.json

View check run for this annotation

@sentry/warden / warden: find-bugs

react-native bumped to 0.85.3 but react-native-macos stays at 0.73.34 (incompatible)

`react-native` was bumped to `0.85.3` but `react-native-macos` remains at `0.73.34`, a 12-minor-version gap — these packages must track the same major/minor version to be compatible, so this combination will fail to build or run.
Comment thread
sentry-warden[bot] marked this conversation as resolved.
"react-native-gesture-handler": "2.14.0",
"react-native-macos": "0.73.34",
Comment thread
sentry-warden[bot] marked this conversation as resolved.
"react-native-reanimated": "3.8.1",
Expand Down
2 changes: 1 addition & 1 deletion samples/react-native/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"@shopify/flash-list": "^2.0.2",
"delay": "^6.0.0",
"react": "19.2.3",
"react-native": "0.85.1",
"react-native": "0.85.3",
"react-native-build-config": "^0.3.2",
"react-native-gesture-handler": "^2.28.0",
"react-native-image-picker": "^8.2.1",
Expand Down
Loading
Loading