Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
"appium-xcuitest-driver": "10.32.1",
"babel-jest": "^29.7.0",
"jest": "^29.7.0",
"react": "18.3.1",
"react-native": "0.77.1",
"react-native": "0.85.3",

Check failure on line 26 in dev-packages/e2e-tests/package.json

View check run for this annotation

@sentry/warden / warden: code-review

React 18 incompatible with React Native 0.85.3

React Native 0.85.3 requires React 19; keeping `react` at `18.3.1` here will likely cause runtime errors in the e2e test environment.
Comment on lines 25 to +26
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React 18 incompatible with React Native 0.85.3

React Native 0.85.3 requires React 19; keeping react at 18.3.1 here will likely cause runtime errors in the e2e test environment.

Evidence
  • samples/react-native/package.json uses react-native: 0.85.3 paired with react: 19.2.3.
  • packages/core/package.json lists react: 19.1.0 alongside the same RN version bump.
  • performance-tests/TestAppPlain/package.json also uses react: 19.2.3 with RN 0.85.x.
  • React Native 0.84 changelog (cited in the PR body) makes Hermes V1 default and removes APIs that depend on React 18 internals, making React 19 a hard requirement.
  • This file alone still declares react: 18.3.1, creating a mismatch that will break the e2e test suite at runtime.

Identified by Warden code-review · M3V-F4Y

"react-native-launch-arguments": "^4.0.2",
"typescript": "4.9.5",
"webdriverio": "^8.27.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@
"oxlint": "^1.56.0",
"oxlint-tsgolint": "^0.17.4",
"react": "19.1.0",
"react-native": "0.80.1",
"react-native": "0.85.3",
"react-test-renderer": "19.1.0",
"rimraf": "^4.1.1",
"ts-jest": "^29.3.1",
Expand Down
2 changes: 1 addition & 1 deletion performance-tests/TestAppPlain/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
},
"dependencies": {
"react": "19.2.3",
"react-native": "0.85.1"
"react-native": "0.85.3"
},
"devDependencies": {
"@babel/core": "^7.25.2",

Check warning on line 15 in performance-tests/TestAppPlain/package.json

View check run for this annotation

@sentry/warden / warden: find-bugs

Stale `engines.node` field allows incompatible Node.js versions after upgrade to react-native 0.85.3

The `engines.node` field is still `>=18`, but React Native 0.84.0 (included in this upgrade) raised the minimum Node.js requirement to v22.11; builds/CI on Node 18–21 will silently proceed and fail at runtime. `samples/react-native/package.json` already correctly declares `>=22.11.0` as a reference.

Check warning on line 15 in performance-tests/TestAppPlain/package.json

View check run for this annotation

@sentry/warden / warden: code-review

engines.node constraint is incompatible with React Native 0.85.x minimum Node requirement

The PR description notes that RN v0.84.0 bumped the minimum Node.js version to v22.11, but the `engines` field still specifies `>=18`, which could allow CI or developers to run this app on an unsupported Node version and encounter unexpected build/runtime failures.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

engines.node constraint is incompatible with React Native 0.85.x minimum Node requirement

The PR description notes that RN v0.84.0 bumped the minimum Node.js version to v22.11, but the engines field still specifies >=18, which could allow CI or developers to run this app on an unsupported Node version and encounter unexpected build/runtime failures.

Evidence
  • PR changelog explicitly lists under v0.84.0 Breaking: "Bump minimum Node.js version to v22.11" (commit 8f10b339d4).
  • react-native is being updated to 0.85.3 (a version beyond 0.84.0), so the new minimum applies.
  • The engines field on line 32–34 of the file remains "node": ">=18", not updated to reflect >=22.11.
  • This means package managers and CI will not warn when an incompatible Node version is used.

Identified by Warden code-review · KWP-4T5

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale engines.node field allows incompatible Node.js versions after upgrade to react-native 0.85.3

The engines.node field is still >=18, but React Native 0.84.0 (included in this upgrade) raised the minimum Node.js requirement to v22.11; builds/CI on Node 18–21 will silently proceed and fail at runtime. samples/react-native/package.json already correctly declares >=22.11.0 as a reference.

Evidence
  • The PR body explicitly lists **Build**: Bump minimum Node.js version to v22.11 as a breaking change in v0.84.0.
  • samples/react-native/package.json (also updated in this PR) sets "node": ">=22.11.0", confirming the correct floor for this react-native version.
  • performance-tests/TestAppPlain/package.json line 15 still reads "node": ">=18" after bumping react-native to 0.85.3.
  • No other guard (.nvmrc, CI matrix, etc.) visible in this file enforces the correct version floor for this app.

Identified by Warden find-bugs · CFF-CVJ

"@babel/preset-env": "^7.25.3",
"@babel/runtime": "^7.25.0",
"@react-native-community/cli": "20.1.0",
Expand Down
2 changes: 1 addition & 1 deletion performance-tests/TestAppSentry/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"@react-native/new-app-screen": "0.85.1",
"@sentry/react-native": "8.11.1",
"react": "19.2.3",
"react-native": "0.85.1"
"react-native": "0.85.3"
},
"devDependencies": {
"@babel/core": "^7.25.2",
Expand Down
2 changes: 1 addition & 1 deletion samples/expo/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"expo-web-browser": "~55.0.9",
"react": "19.2.0",
"react-dom": "19.2.0",
"react-native": "0.83.2",
"react-native": "0.85.3",
"react-native-gesture-handler": "~2.30.0",
"react-native-safe-area-context": "~5.6.0",
"react-native-screens": "~4.23.0",
Expand Down
2 changes: 1 addition & 1 deletion samples/react-native-macos/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@
"@sentry/react": "10.53.1",
"@sentry/react-native": "8.11.1",
"delay": "^6.0.0",
"react": "18.2.0",

Check failure on line 23 in samples/react-native-macos/package.json

View check run for this annotation

@sentry/warden / warden: find-bugs

`react@18.2.0` is incompatible with `react-native@0.85.3`

React Native 0.85 requires React 19; keeping `react@18.2.0` here will cause peer-dependency conflicts and runtime errors (e.g. missing concurrent-mode APIs).
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

react@18.2.0 is incompatible with react-native@0.85.3

React Native 0.85 requires React 19; keeping react@18.2.0 here will cause peer-dependency conflicts and runtime errors (e.g. missing concurrent-mode APIs).

Evidence
  • The hunk bumps react-native to 0.85.3 at line 24 while react remains 18.2.0 at line 23.
  • samples/react-native/package.json, which is correctly updated to react-native@0.85.3, pins react to 19.2.3.
  • React Native 0.84 release notes (included in the PR body) document Hermes V1 as the default and removal of the legacy microtask API — changes that depend on React 19 concurrent semantics.
  • npm's peer-dependency resolution will emit errors or silently install a mismatched tree, leading to unpredictable runtime behaviour.

Identified by Warden find-bugs · 5YH-3UC

"react-native": "0.73.9",
"react-native": "0.85.3",

Check failure on line 24 in samples/react-native-macos/package.json

View check run for this annotation

@sentry/warden / warden: code-review

`react-native` bumped to 0.85.3 but `react-native-macos` and tooling remain on 0.73.x

`react-native-macos` is still pinned at `0.73.34` (which targets RN 0.73.x), while `react-native` is now `0.85.3` — a 12 minor-version gap that will almost certainly cause build or runtime failures. The `@react-native/babel-preset` (0.73.21), `@react-native/metro-config` (0.73.5), and `@react-native/typescript-config` (0.73.1) devDependencies also need to be updated to match.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

react-native bumped to 0.85.3 but react-native-macos and tooling remain on 0.73.x

react-native-macos is still pinned at 0.73.34 (which targets RN 0.73.x), while react-native is now 0.85.3 — a 12 minor-version gap that will almost certainly cause build or runtime failures. The @react-native/babel-preset (0.73.21), @react-native/metro-config (0.73.5), and @react-native/typescript-config (0.73.1) devDependencies also need to be updated to match.

Evidence
  • react-native is set to 0.85.3 at line 24.
  • react-native-macos is pinned at 0.73.34 (line 26); the react-native-macos package follows React Native's versioning scheme, so 0.73.x is only compatible with RN 0.73.x.
  • @react-native/babel-preset, @react-native/metro-config, and @react-native/typescript-config are all hard-pinned to 0.73.x versions (lines 37–39), meaning Metro and Babel transforms will be mismatched with the new RN runtime.
  • The react version is still 18.2.0; RN 0.85.x may require a newer React version depending on its peer deps.
  • None of the other changed files in this PR appear to update these macOS-specific packages to compensate.

Identified by Warden code-review · PRM-WDR

"react-native-gesture-handler": "2.14.0",
"react-native-macos": "0.73.34",

Check failure on line 26 in samples/react-native-macos/package.json

View check run for this annotation

@sentry/warden / warden: find-bugs

`react-native-macos` version is incompatible with the bumped `react-native`

`react-native-macos@0.73.34` must match the major.minor of `react-native`; with `react-native@0.85.3` this will cause a build failure. The devDependencies `@react-native/babel-preset`, `@react-native/metro-config`, and `@react-native/typescript-config` are also still pinned to `0.73.x` and need updating to `0.85.x`.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

react-native-macos version is incompatible with the bumped react-native

react-native-macos@0.73.34 must match the major.minor of react-native; with react-native@0.85.3 this will cause a build failure. The devDependencies @react-native/babel-preset, @react-native/metro-config, and @react-native/typescript-config are also still pinned to 0.73.x and need updating to 0.85.x.

Evidence
  • The hunk bumps react-native from 0.73.9 to 0.85.3 at line 24.
  • react-native-macos on line 26 remains 0.73.34, which is a 12 minor-version gap.
  • react-native-macos is a port that mirrors RN's architecture; mismatched versions are an explicit unsupported configuration that will fail during pod install or native build.
  • The sibling samples/react-native/package.json (correctly updated) pins @react-native/babel-preset, @react-native/metro-config, and @react-native/typescript-config all at 0.85.1; the macOS sample still has these at 0.73.x (lines 40-42 of the file), confirming the update was only partially applied.

Identified by Warden find-bugs · 6TG-M9F

"react-native-reanimated": "3.8.1",
"react-native-safe-area-context": "4.8.0",
"react-native-screens": "3.29.0",
Expand Down
2 changes: 1 addition & 1 deletion samples/react-native/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"@shopify/flash-list": "^2.0.2",
"delay": "^6.0.0",
"react": "19.2.3",
"react-native": "0.85.1",
"react-native": "0.85.3",
"react-native-build-config": "^0.3.2",
"react-native-gesture-handler": "^2.28.0",
"react-native-image-picker": "^8.2.1",
Expand Down
Loading
Loading