Skip to content

ci: Remove pytest-localserver from requirements-testing.txt #6612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexander-alderman-webb merged 11 commits into from
Jun 24, 2026
Merged

ci: Remove pytest-localserver from requirements-testing.txt #6612

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1fab687
ci: Remove pytest-localserver from requirements-testing.txt
alexander-alderman-webb Jun 22, 2026
68c8c69
.
alexander-alderman-webb Jun 22, 2026
c90acd4
.
alexander-alderman-webb Jun 22, 2026
96b2911
.
alexander-alderman-webb Jun 22, 2026
83d4afb
.
alexander-alderman-webb Jun 22, 2026
f5fab33
.
alexander-alderman-webb Jun 22, 2026
f276b89
.
alexander-alderman-webb Jun 22, 2026
636cec3
.
alexander-alderman-webb Jun 22, 2026
da21e1e
.
alexander-alderman-webb Jun 22, 2026
3630a2e
.
alexander-alderman-webb Jun 22, 2026
7e977d9
merge master
alexander-alderman-webb Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion requirements-testing.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@
tomli;python_version<"3.11" # Only needed for pytest on Python < 3.11
pytest-cov
pytest-forked
pytest-localserver
pytest-timeout

Check failure on line 6 in requirements-testing.txt

View check run for this annotation

@sentry/warden / warden: code-review

Removing pytest-localserver breaks tests that depend on it 

`pytest-localserver` is still actively used in `tests/conftest.py` (imported as `pytest_localserver.http.WSGIServer`), which `CapturingServer` extends and which is consumed by `test_transport.py` and `test_gevent.py` — removing it from requirements will cause import errors and test failures.

Check failure on line 6 in requirements-testing.txt

View check run for this annotation

@sentry/warden / warden: find-bugs

Removing pytest-localserver breaks all tests due to hard import in conftest.py 

Removing `pytest-localserver` from `requirements-testing.txt` will cause an `ImportError` at test collection time because `tests/conftest.py` unconditionally imports `from pytest_localserver.http import WSGIServer`, crashing the entire test suite.
Comment thread
sentry-warden[bot] marked this conversation as resolved.
pytest-watch
jsonschema
executing
Expand Down
Loading