ci: Remove pytest-localserver from requirements-testing.txt#6612
Merged
alexander-alderman-webb merged 11 commits intoJun 24, 2026
Merged
ci: Remove pytest-localserver from requirements-testing.txt#6612alexander-alderman-webb merged 11 commits into
pytest-localserver from requirements-testing.txt#6612alexander-alderman-webb merged 11 commits into
@sentry/warden / warden: code-review
completed
Jun 22, 2026 in 0s
1 issue
code-review: Found 1 issue (1 high)
High
Removing pytest-localserver breaks tests that depend on it - `requirements-testing.txt:6`
pytest-localserver is still actively used in tests/conftest.py (imported as pytest_localserver.http.WSGIServer), which CapturingServer extends and which is consumed by test_transport.py and test_gevent.py — removing it from requirements will cause import errors and test failures.
⏱ 17.1s · 42.0k in / 2.0k out · $0.09
Annotations
Check failure on line 6 in requirements-testing.txt
sentry-warden / warden: code-review
Removing pytest-localserver breaks tests that depend on it
`pytest-localserver` is still actively used in `tests/conftest.py` (imported as `pytest_localserver.http.WSGIServer`), which `CapturingServer` extends and which is consumed by `test_transport.py` and `test_gevent.py` — removing it from requirements will cause import errors and test failures.
Loading