Skip to content

ci: Remove pytest-forked from requirements-testing.txt#6611

Merged
alexander-alderman-webb merged 6 commits into
masterfrom
webb/requirements-testing/pytest-forked
Jun 26, 2026
Merged

ci: Remove pytest-forked from requirements-testing.txt#6611
alexander-alderman-webb merged 6 commits into
masterfrom
webb/requirements-testing/pytest-forked

ci: Remove pytest-forked from requirements-testing.txt

02fd9c9
Select commit
Loading
Failed to load commit list.
@sentry/warden / warden completed Jun 22, 2026 in 0s

2 issues

Medium

`opentelemetry`/`otlp`/`potel` tox envs lose `pytest-forked` after removal from requirements-testing.txt - `scripts/populate_tox/config.py:378`

pytest-forked was removed from requirements-testing.txt, and tox.jinja only re-adds it for the common and gevent test environments (common: pytest-forked). The opentelemetry, otlp, and potel envs (defined at tox.jinja lines 124-131) only declare opentelemetry-distro and do not include pytest-forked. Those envs run tests/integrations/opentelemetry/ (via _TESTPATH), where tests such as test_propagator.py and test_experimental.py use @pytest.mark.forked to isolate global-state mutation. Since there is no --strict-markers config (pyproject.toml markers only lists tests_internal_exceptions), the unknown forked marker is silently ignored and those tests run in-process, defeating the intended isolation and risking cross-test pollution/flakiness.

Also found at:

  • scripts/populate_tox/config.py:186
Removing pytest-forked from requirements-testing.txt leaves gevent and opentelemetry tox environments without it - `requirements-testing.txt:5`

After removing pytest-forked from requirements-testing.txt, the gevent and opentelemetry tox environments have no path to install it, yet both contain tests decorated with @pytest.mark.forked that require process isolation.

Also found at:

  • scripts/populate_tox/config.py:378
4 skills analyzed
Skill Findings Duration Cost
security-review 0 3.6s $0.02
code-review 1 5m 17s $1.04
find-bugs 1 4m 18s $1.13
skill-scanner 0 7.8s $0.02

⏱ 9m 46s · 1.1M in / 56.7k out · $2.21