ci: Remove pytest-forked from requirements-testing.txt#6611
1 issue
code-review: Found 1 issue (1 medium)
Medium
`opentelemetry`/`otlp`/`potel` tox envs lose `pytest-forked` after removal from requirements-testing.txt - `scripts/populate_tox/config.py:378`
pytest-forked was removed from requirements-testing.txt, and tox.jinja only re-adds it for the common and gevent test environments (common: pytest-forked). The opentelemetry, otlp, and potel envs (defined at tox.jinja lines 124-131) only declare opentelemetry-distro and do not include pytest-forked. Those envs run tests/integrations/opentelemetry/ (via _TESTPATH), where tests such as test_propagator.py and test_experimental.py use @pytest.mark.forked to isolate global-state mutation. Since there is no --strict-markers config (pyproject.toml markers only lists tests_internal_exceptions), the unknown forked marker is silently ignored and those tests run in-process, defeating the intended isolation and risking cross-test pollution/flakiness.
Also found at:
scripts/populate_tox/config.py:186
⏱ 5m 17s · 559.7k in / 25.6k out · $1.04
Annotations
Check warning on line 378 in scripts/populate_tox/config.py
sentry-warden / warden: code-review
`opentelemetry`/`otlp`/`potel` tox envs lose `pytest-forked` after removal from requirements-testing.txt
`pytest-forked` was removed from `requirements-testing.txt`, and `tox.jinja` only re-adds it for the `common` and `gevent` test environments (`common: pytest-forked`). The `opentelemetry`, `otlp`, and `potel` envs (defined at `tox.jinja` lines 124-131) only declare `opentelemetry-distro` and do not include `pytest-forked`. Those envs run `tests/integrations/opentelemetry/` (via `_TESTPATH`), where tests such as `test_propagator.py` and `test_experimental.py` use `@pytest.mark.forked` to isolate global-state mutation. Since there is no `--strict-markers` config (pyproject.toml `markers` only lists `tests_internal_exceptions`), the unknown `forked` marker is silently ignored and those tests run in-process, defeating the intended isolation and risking cross-test pollution/flakiness.
Check warning on line 186 in scripts/populate_tox/config.py
sentry-warden / warden: code-review
[U4Z-598] `opentelemetry`/`otlp`/`potel` tox envs lose `pytest-forked` after removal from requirements-testing.txt (additional location)
`pytest-forked` was removed from `requirements-testing.txt`, and `tox.jinja` only re-adds it for the `common` and `gevent` test environments (`common: pytest-forked`). The `opentelemetry`, `otlp`, and `potel` envs (defined at `tox.jinja` lines 124-131) only declare `opentelemetry-distro` and do not include `pytest-forked`. Those envs run `tests/integrations/opentelemetry/` (via `_TESTPATH`), where tests such as `test_propagator.py` and `test_experimental.py` use `@pytest.mark.forked` to isolate global-state mutation. Since there is no `--strict-markers` config (pyproject.toml `markers` only lists `tests_internal_exceptions`), the unknown `forked` marker is silently ignored and those tests run in-process, defeating the intended isolation and risking cross-test pollution/flakiness.