ref: Rename _timestamp to _end_timestamp
#6235
2 issues
High
Rename leaves stale `_timestamp` reference in `_span_batcher.py`, causing AttributeError when serializing spans - `sentry_sdk/traces.py:294`
The PR renames StreamedSpan._timestamp to _end_timestamp, but sentry_sdk/_span_batcher.py still accesses item._timestamp at lines 171-172 in _to_transport_format. Since StreamedSpan no longer defines _timestamp, this attribute access will raise AttributeError at runtime whenever a streamed span is serialized for transport, breaking span streaming entirely and preventing end_timestamp from ever being sent to Sentry.
_span_batcher._to_transport_format references removed attribute item._timestamp - `sentry_sdk/traces.py:401-403`
After renaming _timestamp to _end_timestamp on StreamedSpan, sentry_sdk/_span_batcher.py lines 171-172 still access item._timestamp. Combined with __slots__, reading this attribute will raise AttributeError, so serializing any span for transport will fail and no spans will be sent. The serialized payload will also be missing end_timestamp even if the access were tolerated.
4 skills analyzed
| Skill | Findings | Duration | Cost |
|---|---|---|---|
| code-review | 1 | 34.8s | $1.07 |
| find-bugs | 1 | 54.5s | $1.65 |
| skill-scanner | 0 | 14.1s | $0.19 |
| security-review | 0 | 23.6s | $0.12 |
Duration: 2m 7s · Tokens: 598.0k in / 5.8k out · Cost: $3.04 (+verification: $1.97, +extraction: $0.00, +dedup: $0.00)