ref: Rename _timestamp to _end_timestamp
#6235
1 issue
code-review: Found 1 issue (1 high)
High
Rename leaves stale `_timestamp` reference in `_span_batcher.py`, causing AttributeError when serializing spans - `sentry_sdk/traces.py:294`
The PR renames StreamedSpan._timestamp to _end_timestamp, but sentry_sdk/_span_batcher.py still accesses item._timestamp at lines 171-172 in _to_transport_format. Since StreamedSpan no longer defines _timestamp, this attribute access will raise AttributeError at runtime whenever a streamed span is serialized for transport, breaking span streaming entirely and preventing end_timestamp from ever being sent to Sentry.
Duration: 34.8s · Tokens: 154.3k in / 1.6k out · Cost: $1.07 (+verification: $0.79)
Annotations
Check failure on line 294 in sentry_sdk/traces.py
sentry-warden / warden: code-review
Rename leaves stale `_timestamp` reference in `_span_batcher.py`, causing AttributeError when serializing spans
The PR renames `StreamedSpan._timestamp` to `_end_timestamp`, but `sentry_sdk/_span_batcher.py` still accesses `item._timestamp` at lines 171-172 in `_to_transport_format`. Since `StreamedSpan` no longer defines `_timestamp`, this attribute access will raise `AttributeError` at runtime whenever a streamed span is serialized for transport, breaking span streaming entirely and preventing `end_timestamp` from ever being sent to Sentry.