Skip to content

ref: replace concrete TargetFramework string comparisons with TargetFrameworkIdentifier/Version properties #5240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamescrosswell wants to merge 2 commits into
base: main
Choose a base branch
from

Drop unnecessary version checks

6ee1a4a
Select commit
Loading
Failed to load commit list.
Open

ref: replace concrete TargetFramework string comparisons with TargetFrameworkIdentifier/Version properties #5240

Drop unnecessary version checks
6ee1a4a
Select commit
Loading
Failed to load commit list.
@sentry/warden / warden: find-bugs completed May 17, 2026 in 3m 31s

1 issue

find-bugs: Found 1 issue (1 low)

Low

`.NETFramework` condition omits version check, deviating from PR's own stated mapping - `test/Sentry.DiagnosticSource.Tests/Sentry.DiagnosticSource.Tests.csproj:30`

The condition '$(TargetFrameworkIdentifier)' == '.NETFramework' is missing the version guard And '$(TargetFrameworkVersion)' == 'v4.8' that the PR description explicitly documents as the correct replacement for '$(TargetFramework)' == 'net48'. This makes the condition match any .NET Framework version, not just 4.8.

Also found at:

  • src/Sentry.Extensions.Logging/Sentry.Extensions.Logging.csproj:18-21

⏱ 2m 58s · 232.1k in / 29.1k out · $1.20

View more details on @sentry/warden