Skip to content

ref: replace concrete TargetFramework string comparisons with TargetFrameworkIdentifier/Version properties #5240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamescrosswell wants to merge 2 commits into
base: main
Choose a base branch
from

Drop unnecessary version checks

6ee1a4a
Select commit
Loading
Failed to load commit list.
Open

ref: replace concrete TargetFramework string comparisons with TargetFrameworkIdentifier/Version properties #5240

Drop unnecessary version checks
6ee1a4a
Select commit
Loading
Failed to load commit list.
@sentry/warden / warden: code-review completed May 17, 2026 in 1m 33s

1 issue

code-review: Found 1 issue (1 low)

Low

`.NETStandard` condition missing version qualifier, broader than intended - `src/Sentry.Extensions.Logging/Sentry.Extensions.Logging.csproj:18`

The condition was narrowed from the full netstandard2.0 match but the version pin was dropped — '$(TargetFrameworkIdentifier)' == '.NETStandard' matches any NETStandard version, while the PR's own stated mapping and Sentry.Serilog.csproj (another file in this PR) both include And '$(TargetFrameworkVersion)' == 'v2.0'. If netstandard2.1 is ever added to TargetFrameworks, the v2.1.0-pinned packages would be incorrectly applied to it.

Also found at:

  • test/Sentry.DiagnosticSource.IntegrationTests/Sentry.DiagnosticSource.IntegrationTests.csproj:37

⏱ 55.1s · 115.7k in / 11.9k out · $0.73

View more details on @sentry/warden