Skip to content

feat: Automatic trace instrumentation for MAUI #5138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamescrosswell wants to merge 47 commits into
base: main
Choose a base branch
from

fix: prevent race condition when span count approaches the 1000-span …

4a1d0ec
Select commit
Loading
Failed to load commit list.
Open

feat: Automatic trace instrumentation for MAUI #5138

fix: prevent race condition when span count approaches the 1000-span …
4a1d0ec
Select commit
Loading
Failed to load commit list.
@sentry/warden / warden: code-review completed May 13, 2026 in 4m 6s

2 issues

code-review: Found 2 issues (2 low)

Low

Typo in variable name 'resovedRoute' - `src/Sentry.Maui/Internal/MauiEventsBinder.cs:590-592`

Variable resovedRoute is misspelled; rename to resolvedRoute for clarity.

TransactionProfiler not finished on idle-timeout discard path - `src/Sentry/TransactionTracer.cs:268-273`

When OnIdleTimeout discards a transaction with no child spans, it sets _hasFinished = true and disposes the timer but never calls TransactionProfiler?.Finish(). If a profiler was attached (via Hub.StartTransaction when ProfilesSampleRate is set), the profiler will keep running and is never stopped.

⏱ 2m 53s · 1.5M in / 10.6k out · $3.26 (+verification: $0.66, +merge: $0.00)

View more details on @sentry/warden