feat: Automatic trace instrumentation for MAUI #5138
3 issues
Low
Typo in variable name 'resovedRoute' - `src/Sentry.Maui/Internal/MauiEventsBinder.cs:590-592`
Variable resovedRoute is misspelled; rename to resolvedRoute for clarity.
TransactionProfiler not finished on idle-timeout discard path - `src/Sentry/TransactionTracer.cs:268-273`
When OnIdleTimeout discards a transaction with no child spans, it sets _hasFinished = true and disposes the timer but never calls TransactionProfiler?.Finish(). If a profiler was attached (via Hub.StartTransaction when ProfilesSampleRate is set), the profiler will keep running and is never stopped.
Cancelled Shell navigation finished as Ok - `src/Sentry.Maui/Internal/MauiEventsBinder.cs:569-573`
If a Shell navigation is cancelled (via ShellNavigatingEventArgs.Cancel() or fails before Navigated fires), the started nav span will either remain open until a subsequent navigation finishes it as Ok in StartNavigationSpan, or be finished as Ok by an unrelated Navigated. Consider checking e.Cancelled/handling the cancel deferral so the span is finished with SpanStatus.Cancelled.
4 skills analyzed
| Skill | Findings | Duration | Cost |
|---|---|---|---|
| security-review | 0 | 1m 11s | $1.61 |
| code-review | 2 | 2m 53s | $3.26 |
| find-bugs | 1 | 6m 24s | $3.99 |
| gha-security-review | 0 | 3m 38s | $1.67 |
⏱ 14m 7s · 4.8M in / 26.7k out · $10.54 (+verification: $1.80, +merge: $0.00)