Add support for v3 of the AssemblyStore format #4516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## net10 #4516 +/- ##
==========================================
+ Coverage 71.77% 72.70% +0.92%
==========================================
Files 479 476 -3
Lines 17508 17213 -295
Branches 3442 3419 -23
==========================================
- Hits 12567 12515 -52
+ Misses 4090 3841 -249
- Partials 851 857 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bruno-garcia
approved these changes
Sep 22, 2025
Co-authored-by: James Crosswell <[email protected]>
Fix WASM0001 warnings when building Blazor WebAssembly projects that came out from our native bindings. The fix was to change the way we represent `sentry_value_t` in C# side, instead of using `FieldOffset`, we use a backing field along with getters and setters for the variable as a `double`, or `ulong`. Fixes #3369
Co-authored-by: GitHub <[email protected]>
Flash0ver
reviewed
Sep 24, 2025
test/Sentry.Android.AssemblyReader.Tests/ApiApprovalTests.Run.DotNet10_0.verified.txt
Show resolved
Hide resolved
Flash0ver
approved these changes
Sep 24, 2025
Co-authored-by: GitHub <[email protected]> Co-authored-by: James Crosswell <[email protected]>
Co-authored-by: GitHub <[email protected]> Co-authored-by: James Crosswell <[email protected]>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| options.LogDebug("Discarded {0} error ({1}). Captured as managed exception instead.", ex.Type, | ||
| ex.Value); | ||
| return true; | ||
| return null!; |
There was a problem hiding this comment.
Bug: SDK Disablement Bypasses Crash Suppression
The ProcessOnBeforeSend method now checks for DisabledHub and returns early before native crash suppression. This change bypasses the suppression logic when the SDK is disabled, causing duplicate native crash events, contrary to the original design that required suppression regardless of SDK state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4491
Warning
This is a fork of the net10 branch... once that branch has been squashed/merged into the v6 branch we can look at squashing/merging into the same