Skip to content

ref: Use SentrySpan protocol instead of class #6298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2025
+7 −6
Merged

ref: Use SentrySpan protocol instead of class #6298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Sources/Sentry/SentryTimeToDisplayTracker.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@

@interface SentryTimeToDisplayTracker () <SentryFramesTrackerListener>

@property (nonatomic, weak) SentrySpan *initialDisplaySpan;
@property (nonatomic, weak) SentrySpan *fullDisplaySpan;
@property (nonatomic, weak) id<SentrySpan> initialDisplaySpan;
@property (nonatomic, weak) id<SentrySpan> fullDisplaySpan;
@property (nonatomic, strong, readonly) SentryDispatchQueueWrapper *dispatchQueueWrapper;

@end
Expand Down Expand Up @@ -198,9 +198,9 @@
}
}

- (void)addTimeToDisplayMeasurement:(SentrySpan *)span name:(NSString *)name
- (void)addTimeToDisplayMeasurement:(id<SentrySpan>)span name:(NSString *)name
{
NSTimeInterval duration = [span.timestamp timeIntervalSinceDate:span.startTimestamp] * 1000;

Check warning on line 203 in Sources/Sentry/SentryTimeToDisplayTracker.m

View workflow job for this annotation

GitHub Actions / Build XCFramework Slices (Sentry, staticlib, sentry-static) / appletvos 

implicit conversion from nullable pointer 'NSDate * _Nullable' to non-nullable pointer type 'NSDate * _Nonnull' [-Wnullable-to-nonnull-conversion]

Check warning on line 203 in Sources/Sentry/SentryTimeToDisplayTracker.m

View workflow job for this annotation

GitHub Actions / Build XCFramework Slices (Sentry, staticlib, sentry-static) / iphonesimulator 

implicit conversion from nullable pointer 'NSDate * _Nullable' to non-nullable pointer type 'NSDate * _Nonnull' [-Wnullable-to-nonnull-conversion]

Check warning on line 203 in Sources/Sentry/SentryTimeToDisplayTracker.m

View workflow job for this annotation

GitHub Actions / Build XCFramework Slices (Sentry, mh_dylib, -Dynamic, sentry-dynamic) / iphonesimulator 

implicit conversion from nullable pointer 'NSDate * _Nullable' to non-nullable pointer type 'NSDate * _Nonnull' [-Wnullable-to-nonnull-conversion]

Check warning on line 203 in Sources/Sentry/SentryTimeToDisplayTracker.m

View workflow job for this annotation

GitHub Actions / Build XCFramework Slices (Sentry, mh_dylib, -Dynamic, sentry-dynamic) / iphoneos 

implicit conversion from nullable pointer 'NSDate * _Nullable' to non-nullable pointer type 'NSDate * _Nonnull' [-Wnullable-to-nonnull-conversion]

Check warning on line 203 in Sources/Sentry/SentryTimeToDisplayTracker.m

View workflow job for this annotation

GitHub Actions / Build XCFramework Slices (SentrySwiftUI, mh_dylib, sentry-swiftui) / xros 

implicit conversion from nullable pointer 'NSDate * _Nullable' to non-nullable pointer type 'NSDate * _Nonnull' [-Wnullable-to-nonnull-conversion]

Check warning on line 203 in Sources/Sentry/SentryTimeToDisplayTracker.m

View workflow job for this annotation

GitHub Actions / Build XCFramework Slices (SentrySwiftUI, mh_dylib, sentry-swiftui) / iphonesimulator 

implicit conversion from nullable pointer 'NSDate * _Nullable' to non-nullable pointer type 'NSDate * _Nonnull' [-Wnullable-to-nonnull-conversion]

Check warning on line 203 in Sources/Sentry/SentryTimeToDisplayTracker.m

View workflow job for this annotation

GitHub Actions / Build XCFramework Slices (Sentry, staticlib, sentry-static) / iphoneos 

implicit conversion from nullable pointer 'NSDate * _Nullable' to non-nullable pointer type 'NSDate * _Nonnull' [-Wnullable-to-nonnull-conversion]

Check warning on line 203 in Sources/Sentry/SentryTimeToDisplayTracker.m

View workflow job for this annotation

GitHub Actions / Build XCFramework Slices (Sentry, mh_dylib, -Dynamic, sentry-dynamic) / xros 

implicit conversion from nullable pointer 'NSDate * _Nullable' to non-nullable pointer type 'NSDate * _Nonnull' [-Wnullable-to-nonnull-conversion]

Check warning on line 203 in Sources/Sentry/SentryTimeToDisplayTracker.m

View workflow job for this annotation

GitHub Actions / Build XCFramework Slices (SentrySwiftUI, mh_dylib, sentry-swiftui) / appletvos 

implicit conversion from nullable pointer 'NSDate * _Nullable' to non-nullable pointer type 'NSDate * _Nonnull' [-Wnullable-to-nonnull-conversion]

Check warning on line 203 in Sources/Sentry/SentryTimeToDisplayTracker.m

View workflow job for this annotation

GitHub Actions / Build XCFramework Slices (Sentry, mh_dylib, -Dynamic, sentry-dynamic) / maccatalyst 

implicit conversion from nullable pointer 'NSDate * _Nullable' to non-nullable pointer type 'NSDate * _Nonnull' [-Wnullable-to-nonnull-conversion]

Check warning on line 203 in Sources/Sentry/SentryTimeToDisplayTracker.m

View workflow job for this annotation

GitHub Actions / Build XCFramework Slices (SentrySwiftUI, mh_dylib, sentry-swiftui) / iphoneos 

implicit conversion from nullable pointer 'NSDate * _Nullable' to non-nullable pointer type 'NSDate * _Nonnull' [-Wnullable-to-nonnull-conversion]

Check warning on line 203 in Sources/Sentry/SentryTimeToDisplayTracker.m

View workflow job for this annotation

GitHub Actions / Build XCFramework Slices (Sentry, mh_dylib, -Dynamic, sentry-dynamic) / appletvos 

implicit conversion from nullable pointer 'NSDate * _Nullable' to non-nullable pointer type 'NSDate * _Nonnull' [-Wnullable-to-nonnull-conversion]

Check warning on line 203 in Sources/Sentry/SentryTimeToDisplayTracker.m

View workflow job for this annotation

GitHub Actions / Build XCFramework Slices (Sentry, staticlib, sentry-static) / maccatalyst 

implicit conversion from nullable pointer 'NSDate * _Nullable' to non-nullable pointer type 'NSDate * _Nonnull' [-Wnullable-to-nonnull-conversion]

Check warning on line 203 in Sources/Sentry/SentryTimeToDisplayTracker.m

View workflow job for this annotation

GitHub Actions / Build XCFramework Slices (Sentry, staticlib, sentry-static) / xros 

implicit conversion from nullable pointer 'NSDate * _Nullable' to non-nullable pointer type 'NSDate * _Nonnull' [-Wnullable-to-nonnull-conversion]
[span setMeasurement:name value:@(duration) unit:SentryMeasurementUnitDuration.millisecond];
}

Expand Down
7 changes: 4 additions & 3 deletions Sources/Sentry/include/SentryTimeToDisplayTracker.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,12 @@

#if SENTRY_HAS_UIKIT

@class SentrySpan;
@class SentryTracer;
@class SentryDispatchQueueWrapper;
@class UIViewController;

@protocol SentrySpan;

NS_ASSUME_NONNULL_BEGIN

/**
Expand All @@ -19,9 +20,9 @@ NS_ASSUME_NONNULL_BEGIN
@interface SentryTimeToDisplayTracker : NSObject
SENTRY_NO_INIT

@property (nullable, nonatomic, weak, readonly) SentrySpan *initialDisplaySpan;
@property (nullable, nonatomic, weak, readonly) id<SentrySpan> initialDisplaySpan;

@property (nullable, nonatomic, weak, readonly) SentrySpan *fullDisplaySpan;
@property (nullable, nonatomic, weak, readonly) id<SentrySpan> fullDisplaySpan;

@property (nonatomic, readonly) BOOL waitForFullDisplay;

Expand Down
Loading