ref: Use SentrySpan protocol instead of class #6298
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SentrySpan protocol is already part of the public interface and can therefore be used from Swift. The SentrySpan class is still internal to objc. To make this Swift migration easier I changed it to use the protocol, which seems to compile fine
#skip-changelog
Closes #6299
Note
Switch
SentryTimeToDisplayTracker
to theSentrySpan
protocol (id<SentrySpan>
) for span properties and method parameters.SentryTimeToDisplayTracker
to useid<SentrySpan>
instead ofSentrySpan
forinitialDisplaySpan
andfullDisplaySpan
inSources/Sentry/SentryTimeToDisplayTracker.m
andSources/Sentry/include/SentryTimeToDisplayTracker.h
.addTimeToDisplayMeasurement:
to acceptid<SentrySpan>
.@class SentrySpan;
with@protocol SentrySpan;
and adjust property declarations accordingly.Written by Cursor Bugbot for commit 485088e. This will update automatically on new commits. Configure here.