ref(ds): Remove support for reservoir counters#5988
Open
Dav1dde wants to merge 5 commits into
Open
Conversation
Dav1dde
force-pushed
the
dav1d/rm-reservoir-sampling
branch
from
ca335e4 to
2a48494
Compare
Dav1dde
force-pushed
the
dav1d/rm-reservoir-sampling
branch
from
2a48494 to
4c9ef48
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Dav1dde
force-pushed
the
dav1d/rm-reservoir-sampling
branch
from
9a7d6eb to
4f9b9f0
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9758853. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not in use from Sentry for a while now, getsentry/sentry#115365 removes remaining typing of the reservoir rules.
Figured we can remove the rule from the schema without bumping the version as Sentry already no longer creates the rules for a while now. Running a new Relay with an old Sentry is not a supported setup.