-
-
Notifications
You must be signed in to change notification settings - Fork 4
ref: use generic Docker image release pipeline #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
aldy505
wants to merge
5
commits into
getsentry:main
Choose a base branch
from
aldy505:ref/release-docker-image
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+81
−0
Draft
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0e07047
ref: use generic sentry image release pipeline
aldy505 9bc7aeb
Merge remote-tracking branch 'origin/main' into ref/release-docker-image
aldy505 40e2944
Merge remote-tracking branch 'origin/main' into ref/release-docker-image
aldy505 fb1e60f
chore: pin GHA dependencies
aldy505 03c76e8
fix: use correct status provider for craft
aldy505 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| minVersion: "0.27.2" | ||
| changelogPolicy: auto | ||
| artifactProvider: | ||
| name: none | ||
| statusProvider: | ||
| name: github | ||
| config: | ||
| contexts: | ||
| - 'Publish' | ||
| preReleaseCommand: "" | ||
| targets: | ||
| - id: release | ||
| name: docker | ||
| source: ghcr.io/getsentry/objectstore | ||
| target: getsentry/objectstore | ||
| - id: latest | ||
| name: docker | ||
| source: ghcr.io/getsentry/objectstore | ||
| target: getsentry/objectstore | ||
| targetFormat: '{{{target}}}:latest' | ||
| - name: github | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| name: Release GHCR Versioned Image | ||
|
|
||
| on: | ||
| release: | ||
| types: [prereleased, released] | ||
|
|
||
| jobs: | ||
| release-ghcr-version-tag: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Log in to GitHub Container Registry | ||
| uses: docker/login-action@v3 | ||
|
||
| with: | ||
| registry: ghcr.io | ||
| username: ${{ github.actor }} | ||
| password: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Tag release version | ||
| run: | | ||
| docker buildx imagetools create --tag \ | ||
| ghcr.io/getsentry/objectstore:${{ github.ref_name }} \ | ||
| ghcr.io/getsentry/objectstore:${{ github.sha }} | ||
|
|
||
| - name: Tag latest version | ||
| run: | | ||
| docker buildx imagetools create --tag \ | ||
| ghcr.io/getsentry/objectstore:latest \ | ||
| ghcr.io/getsentry/objectstore:${{ github.sha }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| name: self-hosted release | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| version: | ||
| description: Version to release (optional) | ||
| required: false | ||
| force: | ||
| description: Force a release even when there are release-blockers (optional) | ||
| required: false | ||
|
|
||
| schedule: | ||
| # We want the release to be at 9-10am Pacific Time | ||
| # We also want it to be 1 hour before the on-prem release | ||
| - cron: "0 17 15 * *" | ||
|
|
||
| jobs: | ||
| release: | ||
| runs-on: ubuntu-latest | ||
| name: "Release a new objectstore version" | ||
| steps: | ||
| - name: Get auth token | ||
| id: token | ||
| uses: actions/create-github-app-token@df432ceedc7162793a195dd1713ff69aefc7379e # v2.0.6 | ||
| with: | ||
| app-id: ${{ vars.SENTRY_RELEASE_BOT_CLIENT_ID }} | ||
| private-key: ${{ secrets.SENTRY_RELEASE_BOT_PRIVATE_KEY }} | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| token: ${{ steps.token.outputs.token }} | ||
| fetch-depth: 0 | ||
| - name: Prepare release | ||
| uses: getsentry/action-prepare-release@v1 | ||
| env: | ||
| GITHUB_TOKEN: ${{ steps.token.outputs.token }} | ||
| with: | ||
| version: ${{ github.event.inputs.version }} | ||
| force: ${{ github.event.inputs.force }} | ||
| calver: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| # CHANGELOG |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The
.craft.ymlconfigurescraftto wait for a 'Publish' GitHub status check that no workflow sets, blocking releases.Severity: CRITICAL | Confidence: 1.00
🔍 Detailed Analysis
The
.craft.ymlfile configuresstatusProviderto wait for a GitHub status check named 'Publish'. However, no existing workflow in the repository sets this 'Publish' status. This will cause thecraftCLI tool, invoked byaction-prepare-releaseinrelease.yml, to indefinitely wait for a non-existent status, blocking the release pipeline from completing successfully.💡 Suggested Fix
Either remove the
statusProviderconfiguration from.craft.yml, ensure a workflow sets the 'Publish' status, or change the context name to an existing status.🤖 Prompt for AI Agent
Did we get this right? 👍 / 👎 to inform future reviews.
Reference_id: 2703558