Skip to content

Conversation

@aldy505
Copy link
Contributor

@aldy505 aldy505 commented Nov 15, 2025

To help with getting this to self-hosted. If this PR is merged, we won't automatically generate the release for self-hosted, the issue on the publish repo can be safely rejected.

@aldy505 aldy505 requested a review from a team as a code owner November 15, 2025 06:38
.craft.yml Outdated
Comment on lines 8 to 9
contexts:
- 'Publish'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The .craft.yml configures craft to wait for a 'Publish' GitHub status check that no workflow sets, blocking releases.
Severity: CRITICAL | Confidence: 1.00

🔍 Detailed Analysis

The .craft.yml file configures statusProvider to wait for a GitHub status check named 'Publish'. However, no existing workflow in the repository sets this 'Publish' status. This will cause the craft CLI tool, invoked by action-prepare-release in release.yml, to indefinitely wait for a non-existent status, blocking the release pipeline from completing successfully.

💡 Suggested Fix

Either remove the statusProvider configuration from .craft.yml, ensure a workflow sets the 'Publish' status, or change the context name to an existing status.

🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: .craft.yml#L8-L9

Potential issue: The `.craft.yml` file configures `statusProvider` to wait for a GitHub
status check named 'Publish'. However, no existing workflow in the repository sets this
'Publish' status. This will cause the `craft` CLI tool, invoked by
`action-prepare-release` in `release.yml`, to indefinitely wait for a non-existent
status, blocking the release pipeline from completing successfully.

Did we get this right? 👍 / 👎 to inform future reviews.

Reference_id: 2703558

Swatinem
Swatinem previously approved these changes Nov 17, 2025
Copy link
Contributor

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubberstamping, I don’t really understand all the details here.

runs-on: ubuntu-latest
steps:
- name: Log in to GitHub Container Registry
uses: docker/login-action@v3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as you have pinned all the other actions to the SHA in a different PR, might as well do that here as well :-)

@jan-auer jan-auer dismissed Swatinem’s stale review November 17, 2025 09:37

Dismissing review without context

@jan-auer jan-auer marked this pull request as draft November 19, 2025 15:54
@jan-auer
Copy link
Member

Let's please wait with this until we have reached a stable integration of Objectstore into Sentry. After this, we can include it in self-hosted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants