Skip to content

fix(changelog): disable @-mention pings in all publish issues #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vaind wants to merge 1 commit into from
Closed

fix(changelog): disable @-mention pings in all publish issues #885

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions src/commands/prepare.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -964,16 +964,11 @@ export async function prepareMain(argv: PrepareOptions): Promise<any> {
setGitHubActionsOutput('sha', releaseSha);
setGitHubActionsOutput('previous_tag', oldVersion || '');
if (changelogBody) {
// For CalVer releases, replace @-mentions with bold formatting in the
// changelog destined for publish issues, to avoid pinging many
// contributors on regular-cadence releases. The committed CHANGELOG.md
// keeps the original @-mentions (they don't create notifications).
const isCalVer =
argv.newVersion === 'calver' ||
getVersioningPolicy() === VersioningPolicy.CalVer;
const issueChangelog = isCalVer
? disableChangelogMentions(changelogBody)
: changelogBody;
// Replace @-mentions with bold formatting in the changelog destined for
// publish issues, otherwise every contributor in the release gets
// pinged. The committed CHANGELOG.md keeps the original @-mentions
// (they don't create notifications).
const issueChangelog = disableChangelogMentions(changelogBody);

// Write full changelog to a file to avoid E2BIG when the action.yml
// "Request publish" step expands it into an environment variable.
Expand Down
Loading