Repository navigation
Conversation
#755 only stripped @-mentions from the publish-issue changelog for CalVer releases, on the theory that regular-cadence releases are the noisy ones. In practice any release that bundles more than a handful of PRs pings every contributor when the publish issue is created — e.g. getsentry/publish#9728 for devservices 1.5.2 (SemVer) notified everyone listed. Nobody needs a notification because their PR shipped in a release, so apply the same treatment regardless of versioning policy. The committed CHANGELOG.md is unaffected and keeps @-mentions, since those don't notify anyone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
This is by design. The earlier disabling part was for changelog previews as it was pinging everyone on almost every PR. We want people to be pinged when their changes are getting released. Is there a particular reason you want to disable this? |
Contributor
Author
I see, OK then. annoying most of the time but I see the value for people that want to udpate after a release. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The changelog embedded in
getsentry/publishissues still contains@authormentions for non-CalVer releases, so every contributor in the release gets notified. Example: getsentry/publish#9728 (devservices 1.5.2) pinged everyone listed in its changelog.#755 added
disableChangelogMentions()but gated it on CalVer (craft prepare calverorversioning.policy: calver). SemVer and auto-versioned projects still ping, even though the problem is the same.Approach
Drop the CalVer gate so the publish-issue changelog always uses
**author**instead of@author. The committedCHANGELOG.mdis unchanged and keeps its@-mentions, which don't create notifications.Requested by: @${GITHUB_ACTOR}inaction.ymlis intentionally left alone: pinging the person who requested the release is desired.Testing
disableChangelogMentionstests insrc/utils/__tests__/helpers.test.ts. This PR only removes the condition around the call, and there is no handler-level test harness forprepare's Actions outputs.typecheck,lintandprettierpass. Locally, the full test suite gives the same result with and without this change: 1217 passed. The 4 local failures (action.test.ts,prepare-dry-run.e2e.test.ts×2,npm.test.tsOIDC) also fail on a cleanmasterand are environment-related. CI onmasteris green.Follow-up
Consumers pinned to an older Craft SHA (for example devservices, which pins
c6e2f04/ 2.19.0) predate #755 entirely and need their pin bumped to pick this up.🤖 Generated with Claude Code