Added Nocturne's Curtain Call #2577
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| package_name: nocturnes | ||
| genshin_id: 14522 | ||
| key: nocturnescourtaincall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| id: 14522 | ||
| key: "nocturnescourtaincall" | ||
| rarity: 5 | ||
| weapon_class: WEAPON_CATALYST | ||
| image_name: "UI_EquipIcon_Catalyst_Brisingamen" | ||
| base_stats: { | ||
| base_props: { | ||
| prop_type: FIGHT_PROP_BASE_ATTACK | ||
| initial_value: 44.3358 | ||
| curve: GROW_CURVE_ATTACK_304 | ||
| } | ||
| base_props: { | ||
| prop_type: FIGHT_PROP_CRITICAL_HURT | ||
| initial_value: 0.192 | ||
| curve: GROW_CURVE_CRITICAL_301 | ||
| } | ||
| promo_data: { | ||
| max_level: 20 | ||
| } | ||
| promo_data: { | ||
| max_level: 40 | ||
| add_props: { | ||
| prop_type: FIGHT_PROP_BASE_ATTACK | ||
| value: 31.1 | ||
| } | ||
| } | ||
| promo_data: { | ||
| max_level: 50 | ||
| add_props: { | ||
| prop_type: FIGHT_PROP_BASE_ATTACK | ||
| value: 62.2 | ||
| } | ||
| } | ||
| promo_data: { | ||
| max_level: 60 | ||
| add_props: { | ||
| prop_type: FIGHT_PROP_BASE_ATTACK | ||
| value: 93.4 | ||
| } | ||
| } | ||
| promo_data: { | ||
| max_level: 70 | ||
| add_props: { | ||
| prop_type: FIGHT_PROP_BASE_ATTACK | ||
| value: 124.5 | ||
| } | ||
| } | ||
| promo_data: { | ||
| max_level: 80 | ||
| add_props: { | ||
| prop_type: FIGHT_PROP_BASE_ATTACK | ||
| value: 155.6 | ||
| } | ||
| } | ||
| promo_data: { | ||
| max_level: 90 | ||
| add_props: { | ||
| prop_type: FIGHT_PROP_BASE_ATTACK | ||
| value: 186.7 | ||
| } | ||
| } | ||
| } | ||
| name_text_hash_map: 1441327747 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| package nocturnes | ||
|
|
||
| import ( | ||
| "github.com/genshinsim/gcsim/pkg/core" | ||
| "github.com/genshinsim/gcsim/pkg/core/attacks" | ||
| "github.com/genshinsim/gcsim/pkg/core/attributes" | ||
| "github.com/genshinsim/gcsim/pkg/core/event" | ||
| "github.com/genshinsim/gcsim/pkg/core/info" | ||
| "github.com/genshinsim/gcsim/pkg/core/keys" | ||
| "github.com/genshinsim/gcsim/pkg/core/player/character" | ||
| "github.com/genshinsim/gcsim/pkg/modifier" | ||
| ) | ||
|
|
||
| func init() { | ||
| core.RegisterWeaponFunc(keys.NocturnesCourtainCall, NewWeapon) | ||
| } | ||
|
|
||
| const ICDKey = "nocturnes-courtain-call-icd" | ||
|
|
||
| type Weapon struct { | ||
| Index int | ||
| } | ||
|
|
||
| func (w *Weapon) SetIndex(idx int) { w.Index = idx } | ||
| func (w *Weapon) Init() error { return nil } | ||
|
|
||
| func NewWeapon(c *core.Core, char *character.CharWrapper, p info.WeaponProfile) (info.Weapon, error) { | ||
| w := &Weapon{} | ||
| r := p.Refine | ||
|
|
||
| m := make([]float64, attributes.EndStatType) | ||
| m[attributes.HPP] = 0.075 + float64(r)*0.025 | ||
| char.AddStatMod(character.StatMod{ | ||
| Base: modifier.NewBase("nocturnes-courtain-call-hp", -1), | ||
| Amount: func() []float64 { | ||
| return m | ||
| }, | ||
| }) | ||
|
|
||
| onHitF := func(args ...any) { | ||
| atk := args[1].(*info.AttackEvent) | ||
| if atk.Info.ActorIndex != char.Index() { | ||
| return | ||
| } | ||
| if atk.Info.AttackTag < attacks.LunarReactionStartDelim || atk.Info.AttackTag > attacks.DirectLunarReactionEndDelim { | ||
|
Collaborator
There was a problem hiding this comment. You can use |
||
| return | ||
| } | ||
| w.nocturneBuff(c, char, r) | ||
| } | ||
|
|
||
| onReactF := func(args ...any) { | ||
| atk := args[1].(*info.AttackEvent) | ||
| if atk.Info.ActorIndex != char.Index() { | ||
| return | ||
| } | ||
|
|
||
| w.nocturneBuff(c, char, r) | ||
| } | ||
|
|
||
| c.Events.Subscribe(event.OnEnemyHit, onHitF, "nocturnes-courtain-call-buff") | ||
|
Collaborator
There was a problem hiding this comment. I think this should be OnEnemyDamage? Fix spelling on |
||
| c.Events.Subscribe(event.OnLunarCharged, onReactF, "nocturnes-courtain-call-buff") | ||
| c.Events.Subscribe(event.OnLunarBloom, onReactF, "nocturnes-courtain-call-buff") | ||
| // c.Events.Subscribe(event.OnLunarCrystallize, onReactF, "nocturnes-courtain-call-buff") | ||
|
|
||
| return w, nil | ||
| } | ||
|
|
||
| func (w *Weapon) nocturneBuff(c *core.Core, char *character.CharWrapper, r int) { | ||
| if !char.StatusIsActive(ICDKey) { | ||
| char.AddEnergy("nocturnes-courtain-call", 15) | ||
|
Collaborator
There was a problem hiding this comment. The energy scales by refine. |
||
| char.AddStatus(ICDKey, 18*60, true) | ||
| } | ||
|
|
||
| m := make([]float64, attributes.EndStatType) | ||
|
Collaborator
There was a problem hiding this comment. Allocate this array in Init/NewWeapon. Prevents reallocating this array constantly |
||
| m[attributes.HPP] = 0.09 + float64(r)*0.03 | ||
|
Collaborator
There was a problem hiding this comment. should be 0.12 + float64(r)*0.02 |
||
| char.AddStatMod(character.StatMod{ | ||
| Base: modifier.NewBaseWithHitlag("nocturnes-courtain-call-hp", 12*60), | ||
|
Collaborator
There was a problem hiding this comment. Rename the buff to |
||
| AffectedStat: attributes.HPP, | ||
| Amount: func() []float64 { | ||
| return m | ||
| }, | ||
| }) | ||
|
|
||
| c.Events.Subscribe(event.OnEnemyHit, func(args ...any) { | ||
|
Collaborator
There was a problem hiding this comment. Move this to Init/NewWeapon. Only give the buff when the Bountiful Sea's Sacred Wine effect is active. Also need to add a subscription to |
||
| atk := args[1].(*info.AttackEvent) | ||
|
|
||
| if atk.Info.AttackTag < attacks.LunarReactionStartDelim || atk.Info.AttackTag > attacks.DirectLunarReactionEndDelim { | ||
| return | ||
| } | ||
| atk.Snapshot.Stats[attributes.CD] += 0.6 | ||
| }, "nocturnes-courtain-call-buff") | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| --- | ||
| title: > | ||
| Nocturne's Curtain Call | ||
| --- | ||
|
|
||
| import AoETable from "@site/src/components/AoE/AoETable"; | ||
| import IssuesTable from "@site/src/components/Issues/IssuesTable"; | ||
| import NamesList from "@site/src/components/Names/NamesList"; | ||
| import ParamsTable from "@site/src/components/Params/ParamsTable"; | ||
| import FieldsTable from "@site/src/components/Fields/FieldsTable"; | ||
|
|
||
| ## AoE Data | ||
|
|
||
| <AoETable item_key="nocturnescourtaincall" data_src="weapon" /> | ||
|
|
||
| ## Known issues | ||
|
|
||
| <IssuesTable item_key="nocturnescourtaincall" data_src="weapon" /> | ||
|
|
||
| ## Names | ||
|
|
||
| <NamesList item_key="nocturnescourtaincall" data_src="weapon" /> | ||
|
|
||
| ## Params | ||
|
|
||
| <ParamsTable item_key="nocturnescourtaincall" data_src="weapon" /> | ||
|
|
||
| ## Fields | ||
|
|
||
| <FieldsTable item_key="nocturnescourtaincall" data_src="weapon" /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -254,6 +254,9 @@ | |
| "mouun", | ||
| "mouuns" | ||
| ], | ||
| "nocturnescourtaincall": [ | ||
| "nocturnes" | ||
| ], | ||
| "oathsworneye": [ | ||
| "oathsworn" | ||
| ], | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The HP should be
0.08 + float64(r)*0.02