Conversation
updated docs pipeline rerun
| r := p.Refine | ||
|
|
||
| m := make([]float64, attributes.EndStatType) | ||
| m[attributes.HPP] = 0.075 + float64(r)*0.025 |
There was a problem hiding this comment.
The HP should be 0.08 + float64(r)*0.02
| if atk.Info.ActorIndex != char.Index() { | ||
| return | ||
| } | ||
| if atk.Info.AttackTag < attacks.LunarReactionStartDelim || atk.Info.AttackTag > attacks.DirectLunarReactionEndDelim { |
There was a problem hiding this comment.
You can use !attacks.AttackTagIsLunar(atk.Info.AttackTag)
| w.nocturneBuff(c, char, r) | ||
| } | ||
|
|
||
| c.Events.Subscribe(event.OnEnemyHit, onHitF, "nocturnes-courtain-call-buff") |
There was a problem hiding this comment.
I think this should be OnEnemyDamage? Fix spelling on curtain
|
|
||
| func (w *Weapon) nocturneBuff(c *core.Core, char *character.CharWrapper, r int) { | ||
| if !char.StatusIsActive(ICDKey) { | ||
| char.AddEnergy("nocturnes-courtain-call", 15) |
There was a problem hiding this comment.
The energy scales by refine. 13 + float64(r). Change to nocturnes-curtain-call
| } | ||
|
|
||
| m := make([]float64, attributes.EndStatType) | ||
| m[attributes.HPP] = 0.09 + float64(r)*0.03 |
There was a problem hiding this comment.
should be 0.12 + float64(r)*0.02
| }, | ||
| }) | ||
|
|
||
| c.Events.Subscribe(event.OnEnemyHit, func(args ...any) { |
There was a problem hiding this comment.
Move this to Init/NewWeapon. Only give the buff when the Bountiful Sea's Sacred Wine effect is active. Also need to add a subscription to OnLunarChargedReactionAttack to buff CDMG for the individual contribution to Reaction LC.
| m := make([]float64, attributes.EndStatType) | ||
| m[attributes.HPP] = 0.09 + float64(r)*0.03 | ||
| char.AddStatMod(character.StatMod{ | ||
| Base: modifier.NewBaseWithHitlag("nocturnes-courtain-call-hp", 12*60), |
There was a problem hiding this comment.
Rename the buff to nocturnes-curtain-call-buff (note the spelling) and use char.StatModIsActive() for the Crit DMG bonus
| "moonweaversdawn", | ||
| "mountainbracingbolt", | ||
| "mouunsmoon", | ||
| "nocturnescourtaincall", |
There was a problem hiding this comment.
nocturnescurtaincall
| MoonweaversDawn | ||
| MountainBracingBolt | ||
| MouunsMoon | ||
| NocturnesCourtainCall |
There was a problem hiding this comment.
NocturnesCurtainCall
| "mouunsmoon": keys.MouunsMoon, | ||
| "mouun": keys.MouunsMoon, | ||
| "mouuns": keys.MouunsMoon, | ||
| "nocturnescourtaincall": keys.NocturnesCourtainCall, |
There was a problem hiding this comment.
NocturnesCurtainCall
2 participants
Weapon PR checklist:
.generated.jsonfiles)