Skip to content

Fix: emit() drops events silently when socket is disconnected (no retry/queue) (Auto-Generated) #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hotoke-no-Kami merged 2 commits into from
Aug 1, 2026
Merged

Fix: emit() drops events silently when socket is disconnected (no retry/queue) (Auto-Generated) #69

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80364ff
Fix issue #52: update src/services/socketManager.ts
ndyugwu Jul 30, 2026
b7d5eb1
Merge branch 'build' into driptide/issue-52-1785443122860
hotoke-no-Kami Aug 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/services/socketManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ export class SocketManager {
private registeredHandlers = new Map<string, Set<SocketEventHandler>>();

constructor(config: SocketConfig) {
const defaults = {
transports: ['websocket', 'polling'] as ('polling' | 'websocket')[],
const defaultOptions: NonNullable<SocketConfig['options']> = {
transports: ['websocket', 'polling'],
autoConnect: true,
Expand Down Expand Up @@ -122,8 +124,13 @@ export class SocketManager {
*/
emit(event: string, data?: unknown): boolean {
if (this.socket?.connected) {
this.socket.emit(event, data);
return true;
try {
this.socket.emit(event, data);
return true;
} catch (error) {
console.warn('Failed to emit event:', event, error);
return false;
}
}

if (!this.queueEnabled) {
Expand Down
Loading