Fix: emit() drops events silently when socket is disconnected (no retry/queue) (Auto-Generated) - #69
Merged
hotoke-no-Kami merged 2 commits intoAug 1, 2026
Conversation
|
@ndyugwu is attempting to deploy a commit to the Fishon Amos' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@ndyugwu Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #52
This PR was generated by the DripTide AI coder and scoped strictly to issue #52.
Changes
Updated SocketManager.emit to return a boolean, conservatively warn and reject disconnected emits by default, optionally queue disconnected events with a configurable maximum queue size, and flush queued events after connection or reconnection.
Verification
Passed automated self-review (lint + issue-coverage checks).
Linked with
Closes #52so the Drips Wave bot resolves the issue on merge.