-
Notifications
You must be signed in to change notification settings - Fork 43
Added logging of trintrin messages #1013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Unfortunately, @traversaro would you have any suggestion? |
Sorry I had missed this comment. Anyhow, we now:
So hopefully now everything can be installed cleanly, can we rerun the CI? |
No, the problem is still there, but it is due to something else: Basically there is no librobometry build with libboost=1.86.*, that is still needed by ROS as the libboost 1.88 migration is taking a long time. The easiest fix for this is to do a dual build of librobometry with both 1.86 and 1.88 for now. |
|
There is still an incompat between robostack-jazzy and recent YARP, due to libprotobuf: this is something we may want to fix, but this is not the place. I will add a build of trintrin with YARP 3.12.0 and call it a day. |
|
This is now fixed thanks to conda-forge/trintrin-feedstock#3 . The Windows job fails independently. |
Awesome, thanks a lot! |
08f60bc to
656ea54
Compare
656ea54 to
5c6d9c2
Compare
…messages This simplifies the code in the run method
Co-authored-by: Silvio Traversaro <silvio.traversaro@iit.it>
5c6d9c2 to
9ecc663
Compare
|
Also this PR is ready to go |
GiulioRomualdi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor comments
| void extractMetadata(const trintrin::msgs::HumanState& message, | ||
| const std::string& prefix, | ||
| BipedalLocomotion::YarpUtilities::VectorsCollectionMetadata& metadata); | ||
| void extractMetadata(const trintrin::msgs::WearableTargets& message, | ||
| const std::string& prefix, | ||
| BipedalLocomotion::YarpUtilities::VectorsCollectionMetadata& metadata); | ||
| void extractMetadata(const trintrin::msgs::WearableData& message, | ||
| const std::string& prefix, | ||
| BipedalLocomotion::YarpUtilities::VectorsCollectionMetadata& metadata); | ||
|
|
||
| void convertToVectorsCollection(const trintrin::msgs::HumanState& message, | ||
| const std::string& prefix, | ||
| BipedalLocomotion::YarpUtilities::VectorsCollection& collection); | ||
| void convertToVectorsCollection(const trintrin::msgs::WearableTargets& message, | ||
| const std::string& prefix, | ||
| BipedalLocomotion::YarpUtilities::VectorsCollection& collection); | ||
| void convertToVectorsCollection(const trintrin::msgs::WearableData& message, | ||
| const std::string& prefix, | ||
| BipedalLocomotion::YarpUtilities::VectorsCollection& collection); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add the documentation here?
| Eigen::Vector3d trintrinVectorXYZToVector3(const trintrin::msgs::VectorXYZ& vec) | ||
| { | ||
| Eigen::Vector3d eigenVec; | ||
| eigenVec(0) = vec.x; | ||
| eigenVec(1) = vec.y; | ||
| eigenVec(2) = vec.z; | ||
| return eigenVec; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would move it in a separate file
This is on top of #1012
It adds
trintrinas dependency for the logger in order to allow logging the output of the Human IK and gloves