Add liecasadi dependency for casadi backend and fix ik notebook example #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Giulero
approved these changes
Oct 1, 2025
Collaborator
|
Thanks a looooot @xela-95 ! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying the ik example in https://github.com/ami-iit/adam/blob/main/examples/ik.ipynb and it fails because liecasadi is not found.
Since there is also the https://github.com/ami-iit/adam/blob/main/src/adam/casadi/inverse_kinematics.py class in the casadi backend I think that
liecasadishould be an optional dependency of the casadi backend.Let me know if I understood this correctly :)
📚 Documentation preview 📚: https://adam-docs--137.org.readthedocs.build/en/137/