Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document BG to OBJ priority in CGB mode #454

Merged
merged 7 commits into from
Nov 22, 2022
Merged

Document BG to OBJ priority in CGB mode #454

merged 7 commits into from
Nov 22, 2022

Conversation

alloncm
Copy link
Contributor

@alloncm alloncm commented Nov 11, 2022

Closes #443

avivace
avivace requested changes Nov 11, 2022
View reviewed changes
Copy link
Member

@avivace avivace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alloncm ! It looks good to me, but the modifications really need to be made more compliant to the style/formatting of the rest of the documents.

@alloncm alloncm requested a review from avivace November 12, 2022 15:55
ISSOtm
ISSOtm requested changes Nov 13, 2022
View reviewed changes
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alloncm alloncm requested review from ISSOtm and removed request for avivace November 13, 2022 20:54
@avivace
Copy link
Member

avivace commented Nov 14, 2022

@alloncm please update the threads or close them when changing the related lines to allow us to better resume/restart our reviewing

ISSOtm
ISSOtm requested changes Nov 15, 2022
View reviewed changes
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! I like this change, I only have some formatting/styling suggestions left.

alloncm and others added 3 commits November 18, 2022 12:59
@alloncm
Add BG-to-OBJ priority in CGB mode section
f8e4f74 
Add this section at the Tile_Maps.md file
cause this place describe the BG Map attributes and they are
the new addition in CGB mode that cause this confusion
@alloncm
Add references to the BG to OBJ section
7ef1bde 
Add references in the LCD Control section and the OAM section
@alloncm @ISSOtm
Apply formating and styling suggestions
377a7d5 
Co-authored-by: Eldred Habert <[email protected]>
@alloncm
Add a warning reminder about the OBJ's
50ad6f6 
Merge the tip note into a warning with the suggestion
about the priority between OBJ's
@alloncm
Apply new formating for the rules
bad4048
@alloncm alloncm requested a review from ISSOtm November 18, 2022 11:51
ISSOtm
ISSOtm requested changes Nov 22, 2022
View reviewed changes
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright! Almost done.

@ISSOtm ISSOtm requested a review from avivace November 22, 2022 20:22
ISSOtm
ISSOtm requested changes Nov 22, 2022
View reviewed changes
@alloncm alloncm requested review from ISSOtm and removed request for avivace November 22, 2022 21:20
@ISSOtm ISSOtm requested a review from avivace November 22, 2022 21:27
@avivace avivace merged commit 941c05a into gbdev:master Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avivace avivace avivace approved these changes

@ISSOtm ISSOtm ISSOtm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document the CGB OAM vs BG priority
3 participants
@alloncm @avivace @ISSOtm