-
Couldn't load subscription status.
- Fork 194
Implement ROS standard simulation interfaces #790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
This also comments out vendor packages since those are still pinned to Ionic. Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
…ction Signed-off-by: Addisu Z. Taddese <[email protected]>
…struction Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested various services using https://github.com/RobotecAI/q_simulation_interfaces and they work great. Just one minor issue with running the simulate step action multiple times.
| auto action_result = std::make_shared<SimulateStepsAction::Result>(); | ||
| action_result->result.result = Result::RESULT_OPERATION_FAILED; | ||
| action_result->result.error_message = "Another goal is already running"; | ||
| goal_handle->abort(action_result); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When testing the simulate step action, the first action call works fine but subsequent action seems to fail and end up here saying another goal is running.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 7dc79c6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can ticket the simulation step action issue and address that if needed. Otherwise the code looks good.
Signed-off-by: Addisu Z. Taddese <[email protected]>
|
@ros-pull-request-builder retest this please |
|
@Mergifyio backport kilted jazzy |
✅ Backports have been created
|
--------- Signed-off-by: Addisu Z. Taddese <[email protected]> Signed-off-by: Saurabh Kamat <[email protected]> Co-authored-by: Saurabh Kamat <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit ae92d97)
--------- Signed-off-by: Addisu Z. Taddese <[email protected]> Signed-off-by: Saurabh Kamat <[email protected]> Co-authored-by: Saurabh Kamat <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit ae92d97) # Conflicts: # ros_gz_sim/src/gzserver.cpp
🎉 New feature
Toward #732
Summary
Set up
In order to test this, you'll need a source build of gz-sim with the following PRs:
UserCommandsgz-sim#2996I have removed all Gazebo ROS vendor packages temporarily since those are currently pinned to Ionic. With the recent changes removing the version numbers from the packages, having
gz-jettyinstalled, either from binaries or from source, should be sufficient to build this PR.Test it
Install ROS 2 Rolling
Add Gazebo nightlies to your apt sources. Follow https://gazebosim.org/docs/jetty/install_ubuntu/, but use
ubuntu-nightlyinstead ofubuntu-stable.Install
gz-jettyCreate a new workspace and use
vcsto checkout standard_interfaces.reposSource
rollingand install dependenciesBuild workspace
Run tests
colcon test --packages-select ros_gz_simIf you want to run just the tests introduced in this PR, in a new terminal:
Tip
If the build fails with
c++: fatal error, it likely ran out of memory. Try building withcolcon build --parallel-workers=1 --executor sequentialNote
If the build fails due to missing APIs. It is likely that somehow,
ros_gz_simis being build against the Gazebo install in the system instead of the one we are building from source. If this happens, uninstalllibgz-sim10, remove thebuild/ros_gz_simdirectory and build again.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.