Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Oct 17, 2025

🦟 Bug fix

Summary

Previously, the services immediately returned true after adding
the command to the pending commands queue which meant that
the return statuses did not reflect the success or failure of
the subsequent execution of the commands.

Needed for gazebosim/ros_gz#790

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.


This is an automatic backport of pull request #2999 done by [Mergify](https://mergify.com).

…xecuted command (#2999)

Previously, the services immediately returned true after adding
the command to the pending commands queue which meant that
the return statuses did not reflect the success or failure of
the subsequent execution of the commands.
---------

Signed-off-by: Addisu Z. Taddese <[email protected]>
(cherry picked from commit 590e0f4)
@azeey
Copy link
Contributor

azeey commented Oct 22, 2025

@osrf-jenkins run tests please

@azeey
Copy link
Contributor

azeey commented Oct 23, 2025

The windows failure doesn't seem to be related to this since it's also failing on the stable branch: https://build.osrfoundation.org/view/gz-harmonic/job/gz_sim-8-clowin/test_results_analyzer/

There were some failures on jammy:

@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Oct 23, 2025
@azeey azeey merged commit 7b07789 into gz-sim8 Oct 23, 2025
9 of 11 checks passed
@azeey azeey deleted the mergify/bp/gz-sim8/pr-2999 branch October 23, 2025 18:53
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎵 harmonic Gazebo Harmonic

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants