build: add PEP 517-compliant pip install workflow#1
Open
build: add PEP 517-compliant pip install workflow#1
Conversation
gamesh411
force-pushed
the
pip-install-modernization
branch
11 times, most recently
from
cee03a7 to
36ec6a0
Compare
Rewrite setup.py to discover packages from source tree instead of requiring pre-built build_dist/ directory. Enables `pip install .` and `pip install -e .` as alternative to Makefile build. Remove the ldlogger C Extension that was in the original setup.py. It used setuptools Extension to build an .so file, but the runtime needs a logger binary as well (which the setuptools Extension did not produce). Build logging on linux still requires `make package` (which builds ldlogger correctly). Makefile build, Thrift API packages, and frontend build unchanged.
gamesh411
force-pushed
the
pip-install-modernization
branch
from
36ec6a0 to
8fc2a27
Compare
Makefile build does this via extend_version_file.py but rewritten setup.py missed it — rc builds would report 6.28.0 instead of 6.28.0-rc1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite setup.py to discover packages from source tree instead of requiring pre-built build_dist/ directory. Enables
pip install .andpip install -e .as alternative to Makefile build.Remove the ldlogger C Extension that was in the original setup.py. It used setuptools Extension to build a Python-importable .so, but the runtime needs a standalone LD_PRELOAD library and a logger binary — neither of which setuptools Extension produces. The Extension was non-functional:
CodeChecker lognever worked via pip install. Build logging requiresmake package(which builds ldlogger correctly) or an externalcompile_commands.json.Makefile build, Thrift API packages, and frontend build unchanged.