Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IRMA: Edited config for plattform specific assembly #6705

Merged
merged 11 commits into from
Jan 29, 2025

Conversation

aaronKol
Copy link
Contributor

Default irma module is set to FLU-avian.

The user can now specify the sequencing platform used, such that minimap2 works best. The user can also decide if UTRs should be created or not.

Test data now consists of properly paired read files.

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

@wm75 wm75 changed the title Edited config for plattform specific assembly IRMA: Edited config for plattform specific assembly Jan 27, 2025
@wm75 wm75 added the wip label Jan 27, 2025
@bgruening
Copy link
Member

/usr/local/bin/IRMA_RES/scripts/parseSORTresults.pl ERROR: no classification output found! Aborting.
Traceback (most recent call last):
  File "/home/runner/work/tools-iuc/tools-iuc/tools/irma/createMissingFiles.py", line 78, in <module>
    bamHeader = getBamHeaderFromAnyFile()
                ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/tools-iuc/tools-iuc/tools/irma/createMissingFiles.py", line 27, in getBamHeaderFromAnyFile
    anyBamFile = glob.glob(dirPrefix + "*.bam")[0]
                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^
IndexError: list index out of range

@wm75
Copy link
Contributor

wm75 commented Jan 28, 2025

@bgruening, yes, but the root of this error message seems to be that the irma LABEL step doesn't produce the expected output. The current working hypothesis is that this script has a lot of dependencies and at least one of them might be missing from the biocontainer (tests succeed when run locally non-containerized).

@bgruening
Copy link
Member

sed or awk?

@wm75
Copy link
Contributor

wm75 commented Jan 28, 2025

@aaronKol reading through the original IRMA publication it seems that read sorting with LABEL instead / in addition to BLAT comes with only a very small benefit in terms of accuracy, but we know it has a big runtime overhead.
Given the difficulty here to get this mode running in a container why not just stick to BLAT only for now (essentially what you had working in 42056e3)?

@wm75
Copy link
Contributor

wm75 commented Jan 28, 2025

So, now that we know that we don't support LABEL you need to eliminate the advanced_config.sort_step section.

@wm75
Copy link
Contributor

wm75 commented Jan 28, 2025

... and because we are always using minimap I would rename all the SSW_ options in advanced_config.assembly to their MM2 counterparts for clarity, and if set, apply them also in Illumina mode (instead of the -x sr defaults).

aaronKol and others added 2 commits January 28, 2025 17:51
@wm75 wm75 removed the wip label Jan 28, 2025
@wm75 wm75 merged commit 308791d into galaxyproject:main Jan 29, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants