Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mmuphin wrapper #6584
base: main
Are you sure you want to change the base?
Mmuphin wrapper #6584
Changes from 27 commits
298cadd
ef26199
801cc88
f0ca96f
c19da4d
52076ec
bab0879
7c09803
f340c26
4ee8d65
e861c0f
f65885e
7fafc59
f79c79f
1b335f1
d86e487
47d426d
f815e86
f36aa66
090b476
c5af559
e60c159
9c404da
7c2d2d7
c1b167c
550cd60
8d38c99
b6e9c39
5109992
0c902c3
19a33c0
663287a
a139a38
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Covariates can be empty (only correct batch). To handel the python None in R, this should work:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paulzierep this code does not seem to work for some reason when I set covariates input to null. I keep on getting the error : Object 'None' not found.
PS: I removed --- !exists("$covariates_input") from if since it was executing if condition even when covariate was not empty. I believe it is used to just test whether covariate_input exists in the current env , which kept turning false.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have pushed the other updates you asked for below, and working on how to fix this null issue.
a139a38
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please clean those things up? thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please improve all labels and help text. They are not very user-friendly IMHO.
How does a metadata file needs to look like? Or the feature file? "batch"? Maybe "the column in which the batch identifier is species"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bgruening does this work?
5109992
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we usually don't expose those parameters to the user
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bgruening ,so should I remove them ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes and set a useful default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bgruening , I have the made required changes . Does this work ?
19a33c0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test without covariates
Large diffs are not rendered by default.
Large diffs are not rendered by default.