Apply metadata setter for default to conditionals #7197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing code only expects the case like:
```
<actions>
<action name="column_names" type="metadata" default="Geneid,${alignment.element_identifier}" />
</actions>
```
whereas a conditional can be inserted within `<actions>` yielding a case like:
```
<actions>
<conditional name="format">
<when value="something_good">
<action type="metadata" name="column_names" default="one,two,three" />
</when>
</conditional>
</actions>
```
The fact that this is not handled causes the display logic to fail when `column_names` is set for a tabular dataset inside such a conditional. This patch provides a solution for that case.
nsoranzo
reviewed
Jan 10, 2019
mvdbeek
added
kind/enhancement
area/tool-framework
status/review
and removed
triage
labels
bgruening
reviewed
Feb 6, 2019
| <data format="tabular" name="output"> | ||
| <actions> | ||
| <conditional name="variable"> | ||
| <when value="1"> |
There was a problem hiding this comment.
@pvanheus can you fix the indentation here and below?
There was a problem hiding this comment.
I've committed a version with new indentation - is this better?
|
Maybe I'm confused but there doesn't seem to be anything conditional about this logic. This commit (jmchilton@98f273f) on top of your branch adds a second test case in a conditional and causes the first test to fail. |
|
I'm going to put this into WIP until that test passes, is that okay? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code only expects the case like:
whereas a conditional can be inserted within
<actions>yielding a case like:The fact that this is not handled causes the display logic to fail when
column_namesis set for a tabular dataset inside such a conditional. This patch provides a solution for that case.